Assorted cleanup, minor bug fixes, styling fixes, eslint rules (#5165

* fix: Logic error in toast
fix: Remove useless component

* fix: Logout not clearing all stores

* Add icons to notification settings

* Add eslint rule to enforce spaced comment

* Add eslint rule for arrow-body-style

* Add eslint rule to enforce self-closing components

* Add menu to api key settings
Fix: Deleting webhook subscription does not remove from UI
Split webhook subscriptions into active and inactive
Styling updates

app/scenes/Document/components/CommentEditor.tsx

@@ -8,8 +8,6 @@ const extensions = withComments(basicExtensions);
 const CommentEditor = (
   props: EditorProps,
   ref: React.RefObject<SharedEditor>
-) => {
-  return <Editor extensions={extensions} {...props} ref={ref} />;
-};
+) => <Editor extensions={extensions} {...props} ref={ref} />;
 
 export default React.forwardRef(CommentEditor);

app/scenes/Document/components/CommentThread.tsx

@@ -114,10 +114,9 @@ function CommentThread({
             scrollMode: "if-needed",
             behavior: "smooth",
             block: "start",
-            boundary: (parent) => {
+            boundary: (parent) =>
               // Prevents body and other parent elements from being scrolled
-              return parent.id !== "comments";
-            },
+              parent.id !== "comments",
           });
         },
         isVisible ? 0 : sidebarAppearDuration

app/scenes/Document/components/MultiplayerEditor.tsx

@@ -185,13 +185,14 @@ function MultiplayerEditor({ onSynced, ...props }: Props, ref: any) {
     isMounted,
   ]);
 
-  const user = React.useMemo(() => {
-    return {
+  const user = React.useMemo(
+    () => ({
       id: currentUser.id,
       name: currentUser.name,
       color: currentUser.color,
-    };
-  }, [currentUser.id, currentUser.color, currentUser.name]);
+    }),
+    [currentUser.id, currentUser.color, currentUser.name]
+  );
 
   const extensions = React.useMemo(() => {
     if (!remoteProvider) {

app/scenes/Document/components/PublicBreadcrumb.tsx

@@ -49,13 +49,11 @@ const PublicBreadcrumb: React.FC<Props> = ({
     () =>
       pathToDocument(sharedTree, documentId)
         .slice(0, -1)
-        .map((item) => {
-          return {
-            ...item,
-            type: "route",
-            to: sharedDocumentPath(shareId, item.url),
-          };
-        }),
+        .map((item) => ({
+          ...item,
+          type: "route",
+          to: sharedDocumentPath(shareId, item.url),
+        })),
     [sharedTree, shareId, documentId]
   );