yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Unsure filename when downloading an untitled document

Browse Source 
fix: Unsure unique filename when downloading revision
This commit is contained in:
Tom Moor
2022-09-11 14:32:38 +01:00
parent 0fd576cdd5
commit c89567991b
3 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
server/models/Document.ts
View File

@@ -759,6 +759,10 @@ class Document extends ParanoidModel {
return undefined; return undefined;
}; };
get titleWithDefault(): string {
return this.title || "Untitled";
}
/** /**
* Get a list of users that have collaborated on this document * Get a list of users that have collaborated on this document
* *

6
server/routes/api/documents.ts
View File

@@ -472,9 +472,9 @@ router.post(
ctx.set("Content-Type", contentType); ctx.set("Content-Type", contentType);
ctx.set( ctx.set(
"Content-Disposition", "Content-Disposition",
`attachment; filename="${slugify(document.title)}.${mime.extension( `attachment; filename="${slugify(
contentType document.titleWithDefault
)}"` )}.${mime.extension(contentType)}"`
); );
ctx.body = content; ctx.body = content;
return; return;

4
server/routes/api/revisions.ts
View File

@@ -79,7 +79,9 @@ router.post("revisions.diff", auth(), async (ctx) => {
ctx.set("Content-Type", "text/html"); ctx.set("Content-Type", "text/html");
ctx.set( ctx.set(
"Content-Disposition", "Content-Disposition",
`attachment; filename="${slugify(document.title)}.html"` `attachment; filename="${slugify(document.titleWithDefault)}-${
revision.id
}.html"`
); );
ctx.body = content; ctx.body = content;
return; return;