fix: Unsure filename when downloading an untitled document

fix: Unsure unique filename when downloading revision

server/models/Document.ts

@@ -759,6 +759,10 @@ class Document extends ParanoidModel {
     return undefined;
   };
 
+  get titleWithDefault(): string {
+    return this.title || "Untitled";
+  }
+
   /**
    * Get a list of users that have collaborated on this document
    *

server/routes/api/documents.ts

@@ -472,9 +472,9 @@ router.post(
       ctx.set("Content-Type", contentType);
       ctx.set(
         "Content-Disposition",
-        `attachment; filename="${slugify(document.title)}.${mime.extension(
-          contentType
-        )}"`
+        `attachment; filename="${slugify(
+          document.titleWithDefault
+        )}.${mime.extension(contentType)}"`
       );
       ctx.body = content;
       return;

server/routes/api/revisions.ts

@@ -79,7 +79,9 @@ router.post("revisions.diff", auth(), async (ctx) => {
     ctx.set("Content-Type", "text/html");
     ctx.set(
       "Content-Disposition",
-      `attachment; filename="${slugify(document.title)}.html"`
+      `attachment; filename="${slugify(document.titleWithDefault)}-${
+        revision.id
+      }.html"`
     );
     ctx.body = content;
     return;