yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Incorrect policies returned from documents.update (#7111)

Browse Source 
* fix: Incorrect policies returned from documents.update

* Regression test
This commit is contained in:
Tom Moor
2024-06-21 19:37:39 -04:00
committed by GitHub
parent 4897f001e4
commit 9e5d5c0347
2 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
server/routes/api/documents/documents.test.ts
View File

@@ -3316,13 +3316,14 @@ describe("#documents.update", () => {
body: { body: {
token: user.getJwtToken(), token: user.getJwtToken(),
id: document.id, id: document.id,
text: "Changed text", title: "Changed text",
}, },
}); });
const body = await res.json(); const body = await res.json();
expect(res.status).toEqual(200); expect(res.status).toEqual(200);
expect(body.data.text).toBe("Changed text"); expect(body.data.title).toBe("Changed text");
expect(body.data.updatedBy.id).toBe(user.id); expect(body.data.updatedBy.id).toBe(user.id);
expect(body.policies[0].abilities.update).toEqual(true);
}); });
it("does not allow editing by read-only collection user", async () => { it("does not allow editing by read-only collection user", async () => {

4
server/routes/api/documents/documents.ts
View File

@@ -996,7 +996,7 @@ router.post(
const { user } = ctx.state.auth; const { user } = ctx.state.auth;
let collection: Collection | null | undefined; let collection: Collection | null | undefined;
const document = await Document.findByPk(id, { let document = await Document.findByPk(id, {
userId: user.id, userId: user.id,
includeState: true, includeState: true,
transaction, transaction,
@@ -1037,7 +1037,7 @@ router.post(
} }
} }
await documentUpdater({ document = await documentUpdater({
document, document,
user, user,
...input, ...input,