From 9e5d5c03473ec3d48852b7b4fdcbaf70f9aec7aa Mon Sep 17 00:00:00 2001
From: Tom Moor <tom@getoutline.com>
Date: Fri, 21 Jun 2024 19:37:39 -0400
Subject: [PATCH] fix: Incorrect policies returned from documents.update
 (#7111)

* fix: Incorrect policies returned from documents.update

* Regression test
---
 server/routes/api/documents/documents.test.ts | 5 +++--
 server/routes/api/documents/documents.ts      | 4 ++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/server/routes/api/documents/documents.test.ts b/server/routes/api/documents/documents.test.ts
index a5685ef7e..793dc6b1b 100644
--- a/server/routes/api/documents/documents.test.ts
+++ b/server/routes/api/documents/documents.test.ts
@@ -3316,13 +3316,14 @@ describe("#documents.update", () => {
       body: {
         token: user.getJwtToken(),
         id: document.id,
-        text: "Changed text",
+        title: "Changed text",
       },
     });
     const body = await res.json();
     expect(res.status).toEqual(200);
-    expect(body.data.text).toBe("Changed text");
+    expect(body.data.title).toBe("Changed text");
     expect(body.data.updatedBy.id).toBe(user.id);
+    expect(body.policies[0].abilities.update).toEqual(true);
   });
 
   it("does not allow editing by read-only collection user", async () => {
diff --git a/server/routes/api/documents/documents.ts b/server/routes/api/documents/documents.ts
index fa6b7bbd8..ba4a1056f 100644
--- a/server/routes/api/documents/documents.ts
+++ b/server/routes/api/documents/documents.ts
@@ -996,7 +996,7 @@ router.post(
     const { user } = ctx.state.auth;
     let collection: Collection | null | undefined;
 
-    const document = await Document.findByPk(id, {
+    let document = await Document.findByPk(id, {
       userId: user.id,
       includeState: true,
       transaction,
@@ -1037,7 +1037,7 @@ router.post(
       }
     }
 
-    await documentUpdater({
+    document = await documentUpdater({
       document,
       user,
       ...input,