yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: Improve clarity of 'Shared links' page in settings

Browse Source
This commit is contained in:
Tom Moor
2024-03-17 13:17:03 -04:00
parent 4e47f4c1e2
commit 64bcf40edd
4 changed files with 4 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/hooks/useSettingsConfig.ts
View File

@@ -5,7 +5,7 @@ import {
CodeIcon, CodeIcon,
UserIcon, UserIcon,
GroupIcon, GroupIcon,
LinkIcon, GlobeIcon,
TeamIcon, TeamIcon,
BeakerIcon, BeakerIcon,
BuildingBlocksIcon, BuildingBlocksIcon,
@@ -148,7 +148,7 @@ const useSettingsConfig = () => {
component: Shares, component: Shares,
enabled: true, enabled: true,
group: t("Workspace"), group: t("Workspace"),
icon: LinkIcon, icon: GlobeIcon,
}, },
{ {
name: t("Import"), name: t("Import"),

4
app/scenes/Settings/Shares.tsx
View File

@@ -1,6 +1,6 @@
import sortBy from "lodash/sortBy"; import sortBy from "lodash/sortBy";
import { observer } from "mobx-react"; import { observer } from "mobx-react";
import { LinkIcon, WarningIcon } from "outline-icons"; import { GlobeIcon, WarningIcon } from "outline-icons";
import * as React from "react"; import * as React from "react";
import { useTranslation, Trans } from "react-i18next"; import { useTranslation, Trans } from "react-i18next";
import { Link } from "react-router-dom"; import { Link } from "react-router-dom";
@@ -68,7 +68,7 @@ function Shares() {
}, [shares.orderedData, shareIds]); }, [shares.orderedData, shareIds]);
return ( return (
<Scene title={t("Shared Links")} icon={<LinkIcon />} wide> <Scene title={t("Shared Links")} icon={<GlobeIcon />} wide>
<Heading>{t("Shared Links")}</Heading> <Heading>{t("Shared Links")}</Heading>
{can.update && !canShareDocuments && ( {can.update && !canShareDocuments && (

16
app/scenes/Settings/components/SharesTable.tsx
View File

@@ -1,5 +1,4 @@
import { observer } from "mobx-react"; import { observer } from "mobx-react";
import { CheckmarkIcon } from "outline-icons";
import * as React from "react"; import * as React from "react";
import { useTranslation } from "react-i18next"; import { useTranslation } from "react-i18next";
import { useTheme } from "styled-components"; import { useTheme } from "styled-components";
@@ -8,7 +7,6 @@ import Avatar from "~/components/Avatar";
import Flex from "~/components/Flex"; import Flex from "~/components/Flex";
import TableFromParams from "~/components/TableFromParams"; import TableFromParams from "~/components/TableFromParams";
import Time from "~/components/Time"; import Time from "~/components/Time";
import Tooltip from "~/components/Tooltip";
import ShareMenu from "~/menus/ShareMenu"; import ShareMenu from "~/menus/ShareMenu";
type Props = Omit<React.ComponentProps<typeof TableFromParams>, "columns"> & { type Props = Omit<React.ComponentProps<typeof TableFromParams>, "columns"> & {
@@ -63,20 +61,6 @@ function SharesTable({ canManage, data, ...rest }: Props) {
value ? <Time dateTime={value} addSuffix /> : null value ? <Time dateTime={value} addSuffix /> : null
), ),
}, },
{
id: "includeChildDocuments",
Header: t("Shared nested"),
accessor: "includeChildDocuments",
Cell: observer(({ value }: { value: string }) =>
value ? (
<Flex align="center">
<Tooltip content={t("Nested documents are publicly available")}>
<CheckmarkIcon color={theme.accent} />
</Tooltip>
</Flex>
) : null
),
},
hasDomain hasDomain
? { ? {
id: "domain", id: "domain",

2
shared/i18n/locales/en_US/translation.json
View File

@@ -794,8 +794,6 @@
"Last accessed": "Last accessed", "Last accessed": "Last accessed",
"Shared by": "Shared by", "Shared by": "Shared by",
"Date shared": "Date shared", "Date shared": "Date shared",
"Shared nested": "Shared nested",
"Nested documents are publicly available": "Nested documents are publicly available",
"Domain": "Domain", "Domain": "Domain",
"Views": "Views", "Views": "Views",
"Everyone": "Everyone", "Everyone": "Everyone",