From 64bcf40edddb693f908570ac2f0d2a5529ee0284 Mon Sep 17 00:00:00 2001
From: Tom Moor <tom.moor@gmail.com>
Date: Sun, 17 Mar 2024 13:17:03 -0400
Subject: [PATCH] chore: Improve clarity of 'Shared links' page in settings

---
 app/hooks/useSettingsConfig.ts                 |  4 ++--
 app/scenes/Settings/Shares.tsx                 |  4 ++--
 app/scenes/Settings/components/SharesTable.tsx | 16 ----------------
 shared/i18n/locales/en_US/translation.json     |  2 --
 4 files changed, 4 insertions(+), 22 deletions(-)

diff --git a/app/hooks/useSettingsConfig.ts b/app/hooks/useSettingsConfig.ts
index 572f106bb..38725098f 100644
--- a/app/hooks/useSettingsConfig.ts
+++ b/app/hooks/useSettingsConfig.ts
@@ -5,7 +5,7 @@ import {
   CodeIcon,
   UserIcon,
   GroupIcon,
-  LinkIcon,
+  GlobeIcon,
   TeamIcon,
   BeakerIcon,
   BuildingBlocksIcon,
@@ -148,7 +148,7 @@ const useSettingsConfig = () => {
         component: Shares,
         enabled: true,
         group: t("Workspace"),
-        icon: LinkIcon,
+        icon: GlobeIcon,
       },
       {
         name: t("Import"),
diff --git a/app/scenes/Settings/Shares.tsx b/app/scenes/Settings/Shares.tsx
index 8e7f4048a..7d8fd2970 100644
--- a/app/scenes/Settings/Shares.tsx
+++ b/app/scenes/Settings/Shares.tsx
@@ -1,6 +1,6 @@
 import sortBy from "lodash/sortBy";
 import { observer } from "mobx-react";
-import { LinkIcon, WarningIcon } from "outline-icons";
+import { GlobeIcon, WarningIcon } from "outline-icons";
 import * as React from "react";
 import { useTranslation, Trans } from "react-i18next";
 import { Link } from "react-router-dom";
@@ -68,7 +68,7 @@ function Shares() {
   }, [shares.orderedData, shareIds]);
 
   return (
-    <Scene title={t("Shared Links")} icon={<LinkIcon />} wide>
+    <Scene title={t("Shared Links")} icon={<GlobeIcon />} wide>
       <Heading>{t("Shared Links")}</Heading>
 
       {can.update && !canShareDocuments && (
diff --git a/app/scenes/Settings/components/SharesTable.tsx b/app/scenes/Settings/components/SharesTable.tsx
index a0ac839ef..66add0a2f 100644
--- a/app/scenes/Settings/components/SharesTable.tsx
+++ b/app/scenes/Settings/components/SharesTable.tsx
@@ -1,5 +1,4 @@
 import { observer } from "mobx-react";
-import { CheckmarkIcon } from "outline-icons";
 import * as React from "react";
 import { useTranslation } from "react-i18next";
 import { useTheme } from "styled-components";
@@ -8,7 +7,6 @@ import Avatar from "~/components/Avatar";
 import Flex from "~/components/Flex";
 import TableFromParams from "~/components/TableFromParams";
 import Time from "~/components/Time";
-import Tooltip from "~/components/Tooltip";
 import ShareMenu from "~/menus/ShareMenu";
 
 type Props = Omit<React.ComponentProps<typeof TableFromParams>, "columns"> & {
@@ -63,20 +61,6 @@ function SharesTable({ canManage, data, ...rest }: Props) {
             value ? <Time dateTime={value} addSuffix /> : null
           ),
         },
-        {
-          id: "includeChildDocuments",
-          Header: t("Shared nested"),
-          accessor: "includeChildDocuments",
-          Cell: observer(({ value }: { value: string }) =>
-            value ? (
-              <Flex align="center">
-                <Tooltip content={t("Nested documents are publicly available")}>
-                  <CheckmarkIcon color={theme.accent} />
-                </Tooltip>
-              </Flex>
-            ) : null
-          ),
-        },
         hasDomain
           ? {
               id: "domain",
diff --git a/shared/i18n/locales/en_US/translation.json b/shared/i18n/locales/en_US/translation.json
index dbc8f9849..d9129e04c 100644
--- a/shared/i18n/locales/en_US/translation.json
+++ b/shared/i18n/locales/en_US/translation.json
@@ -794,8 +794,6 @@
   "Last accessed": "Last accessed",
   "Shared by": "Shared by",
   "Date shared": "Date shared",
-  "Shared nested": "Shared nested",
-  "Nested documents are publicly available": "Nested documents are publicly available",
   "Domain": "Domain",
   "Views": "Views",
   "Everyone": "Everyone",