yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Remove breaking requirement to not pass collectionId with parentDocumentId.

Browse Source 
This was regressed as part of 95b9453269 and unfortunately is a breaking change for API consumers
This commit is contained in:
Tom Moor
2024-06-21 20:34:31 -04:00
parent f17ce9d50b
commit 5ddc36555d
2 changed files with 0 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
server/routes/api/documents/documents.test.ts
View File

@@ -2868,26 +2868,6 @@ describe("#documents.create", () => {
);
});
it("should not allow creating a nested doc with a collection", async () => {
const team = await buildTeam();
const user = await buildUser({ teamId: team.id });
const res = await server.post("/api/documents.create", {
body: {
token: user.getJwtToken(),
collectionId: "d7a4eb73-fac1-4028-af45-d7e34d54db8e",
parentDocumentId: "d7a4eb73-fac1-4028-af45-d7e34d54db8e",
title: "nested doc",
text: "nested doc without collection",
},
});
const body = await res.json();
expect(res.status).toEqual(400);
expect(body.message).toBe(
"collectionId is inferred when creating a nested document"
);
});
it("should not allow very long titles", async () => {
const team = await buildTeam();
const user = await buildUser({ teamId: team.id });

3
server/routes/api/documents/schema.ts
View File

@@ -348,9 +348,6 @@ export const DocumentsCreateSchema = BaseSchema.extend({
template: z.boolean().optional(),
}),
})
.refine((req) => !req.body.parentDocumentId || !req.body.collectionId, {
message: "collectionId is inferred when creating a nested document",
})
.refine((req) => !(req.body.template && !req.body.collectionId), {
message: "collectionId is required to create a template document",
})