* Comment model * Framework, model, policy, presenter, api endpoint etc * Iteration, first pass of UI * fixes, refactors * Comment commands * comment socket support * typing indicators * comment component, styling * wip * right sidebar resize * fix: CMD+Enter submit * Add usePersistedState fix: Main page scrolling on comment highlight * drafts * Typing indicator * refactor * policies * Click thread to highlight Improve comment timestamps * padding * Comment menu v1 * Change comments to use editor * Basic comment editing * fix: Hide commenting button when disabled at team level * Enable opening sidebar without mark * Move selected comment to location state * Add comment delete confirmation * Add comment count to document meta * fix: Comment sidebar togglable Add copy link to comment * stash * Restore History changes * Refactor right sidebar to allow for comment animation * Update to new router best practices * stash * Various improvements * stash * Handle click outside * Fix incorrect placeholder in input fix: Input box appearing on other sessions erroneously * stash * fix: Don't leave orphaned child comments * styling * stash * Enable comment toggling again * Edit styling, merge conflicts * fix: Cannot navigate from insights to comments * Remove draft comment mark on click outside * Fix: Empty comment sidebar, tsc * Remove public toggle * fix: All comments are recessed fix: Comments should not be printed * fix: Associated mark should be removed on comment delete * Revert unused changes * Empty state, basic RTL support * Create dont toggle comment mark * Make it feel more snappy * Highlight active comment in text * fix animation * RTL support * Add reply CTA * Translations
319 lines
9.7 KiB
TypeScript
319 lines
9.7 KiB
TypeScript
import http, { IncomingMessage } from "http";
|
|
import { Duplex } from "stream";
|
|
import invariant from "invariant";
|
|
import Koa from "koa";
|
|
import IO from "socket.io";
|
|
import { createAdapter } from "socket.io-redis";
|
|
import Logger from "@server/logging/Logger";
|
|
import Metrics from "@server/logging/Metrics";
|
|
import * as Tracing from "@server/logging/tracer";
|
|
import { traceFunction } from "@server/logging/tracing";
|
|
import { Document, Collection, View, User } from "@server/models";
|
|
import { can } from "@server/policies";
|
|
import ShutdownHelper, { ShutdownOrder } from "@server/utils/ShutdownHelper";
|
|
import { getUserForJWT } from "@server/utils/jwt";
|
|
import { websocketQueue } from "../queues";
|
|
import WebsocketsProcessor from "../queues/processors/WebsocketsProcessor";
|
|
import Redis from "../redis";
|
|
|
|
type SocketWithAuth = IO.Socket & {
|
|
client: IO.Socket["client"] & {
|
|
user?: User;
|
|
};
|
|
};
|
|
|
|
export default function init(
|
|
app: Koa,
|
|
server: http.Server,
|
|
serviceNames: string[]
|
|
) {
|
|
const path = "/realtime";
|
|
|
|
// Websockets for events and non-collaborative documents
|
|
const io = new IO.Server(server, {
|
|
path,
|
|
serveClient: false,
|
|
cookie: false,
|
|
cors: {
|
|
origin: "*",
|
|
methods: ["GET", "POST"],
|
|
},
|
|
});
|
|
|
|
// Remove the upgrade handler that we just added when registering the IO engine
|
|
// And re-add it with a check to only handle the realtime path, this allows
|
|
// collaboration websockets to exist in the same process as engine.io.
|
|
const listeners = server.listeners("upgrade");
|
|
const ioHandleUpgrade = listeners.pop();
|
|
|
|
if (ioHandleUpgrade) {
|
|
server.removeListener(
|
|
"upgrade",
|
|
ioHandleUpgrade as (...args: any[]) => void
|
|
);
|
|
}
|
|
|
|
server.on("upgrade", function (
|
|
req: IncomingMessage,
|
|
socket: Duplex,
|
|
head: Buffer
|
|
) {
|
|
if (req.url?.startsWith(path)) {
|
|
invariant(ioHandleUpgrade, "Existing upgrade handler must exist");
|
|
ioHandleUpgrade(req, socket, head);
|
|
return;
|
|
}
|
|
|
|
if (serviceNames.includes("collaboration")) {
|
|
// Nothing to do, the collaboration service will handle this request
|
|
return;
|
|
}
|
|
|
|
// If the collaboration service isn't running then we need to close the connection
|
|
socket.end(`HTTP/1.1 400 Bad Request\r\n`);
|
|
});
|
|
|
|
ShutdownHelper.add("websockets", ShutdownOrder.normal, async () => {
|
|
Metrics.gaugePerInstance("websockets.count", 0);
|
|
});
|
|
|
|
io.adapter(
|
|
createAdapter({
|
|
pubClient: Redis.defaultClient,
|
|
subClient: Redis.defaultSubscriber,
|
|
})
|
|
);
|
|
|
|
io.of("/").adapter.on("error", (err: Error) => {
|
|
if (err.name === "MaxRetriesPerRequestError") {
|
|
Logger.error("Redis maximum retries exceeded in socketio adapter", err);
|
|
throw err;
|
|
} else {
|
|
Logger.error("Redis error in socketio adapter", err);
|
|
}
|
|
});
|
|
|
|
io.on("connection", (socket: SocketWithAuth) => {
|
|
Metrics.increment("websockets.connected");
|
|
Metrics.gaugePerInstance("websockets.count", io.engine.clientsCount);
|
|
|
|
socket.on("authentication", async function (data) {
|
|
try {
|
|
await authenticate(socket, data);
|
|
Logger.debug("websockets", `Authenticated socket ${socket.id}`);
|
|
|
|
socket.emit("authenticated", true);
|
|
void authenticated(io, socket);
|
|
} catch (err) {
|
|
Logger.error(`Authentication error socket ${socket.id}`, err);
|
|
socket.emit("unauthorized", { message: err.message }, function () {
|
|
socket.disconnect();
|
|
});
|
|
}
|
|
});
|
|
|
|
socket.on("disconnect", async () => {
|
|
Metrics.increment("websockets.disconnected");
|
|
Metrics.gaugePerInstance("websockets.count", io.engine.clientsCount);
|
|
await Redis.defaultClient.hdel(socket.id, "userId");
|
|
});
|
|
|
|
setTimeout(function () {
|
|
// If the socket didn't authenticate after connection, disconnect it
|
|
if (!socket.client.user) {
|
|
Logger.debug("websockets", `Disconnecting socket ${socket.id}`);
|
|
|
|
// @ts-expect-error should be boolean
|
|
socket.disconnect("unauthorized");
|
|
}
|
|
}, 1000);
|
|
});
|
|
|
|
// Handle events from event queue that should be sent to the clients down ws
|
|
const websockets = new WebsocketsProcessor();
|
|
websocketQueue.process(
|
|
traceFunction({
|
|
serviceName: "websockets",
|
|
spanName: "process",
|
|
isRoot: true,
|
|
})(async function (job) {
|
|
const event = job.data;
|
|
|
|
Tracing.setResource(`Processor.WebsocketsProcessor`);
|
|
|
|
websockets.perform(event, io).catch((error) => {
|
|
Logger.error("Error processing websocket event", error, {
|
|
event,
|
|
});
|
|
});
|
|
})
|
|
);
|
|
}
|
|
|
|
async function authenticated(io: IO.Server, socket: SocketWithAuth) {
|
|
const { user } = socket.client;
|
|
if (!user) {
|
|
throw new Error("User not returned from auth");
|
|
}
|
|
|
|
// the rooms associated with the current team
|
|
// and user so we can send authenticated events
|
|
const rooms = [`team-${user.teamId}`, `user-${user.id}`];
|
|
|
|
// the rooms associated with collections this user
|
|
// has access to on connection. New collection subscriptions
|
|
// are managed from the client as needed through the 'join' event
|
|
const collectionIds: string[] = await user.collectionIds();
|
|
|
|
collectionIds.forEach((collectionId) =>
|
|
rooms.push(`collection-${collectionId}`)
|
|
);
|
|
|
|
// join all of the rooms at once
|
|
socket.join(rooms);
|
|
|
|
// allow the client to request to join rooms
|
|
socket.on("join", async (event) => {
|
|
// user is joining a collection channel, because their permissions have
|
|
// changed, granting them access.
|
|
if (event.collectionId) {
|
|
const collection = await Collection.scope({
|
|
method: ["withMembership", user.id],
|
|
}).findByPk(event.collectionId);
|
|
|
|
if (can(user, "read", collection)) {
|
|
await socket.join(`collection-${event.collectionId}`);
|
|
Metrics.increment("websockets.collections.join");
|
|
}
|
|
}
|
|
|
|
// user is joining a document channel, because they have navigated to
|
|
// view a document.
|
|
if (event.documentId) {
|
|
const document = await Document.findByPk(event.documentId, {
|
|
userId: user.id,
|
|
});
|
|
|
|
if (can(user, "read", document)) {
|
|
const room = `document-${event.documentId}`;
|
|
await View.touch(event.documentId, user.id, event.isEditing);
|
|
const editing = await View.findRecentlyEditingByDocument(
|
|
event.documentId
|
|
);
|
|
|
|
await socket.join(room);
|
|
Metrics.increment("websockets.documents.join");
|
|
|
|
// let everyone else in the room know that a new user joined
|
|
io.to(room).emit("user.join", {
|
|
userId: user.id,
|
|
documentId: event.documentId,
|
|
isEditing: event.isEditing,
|
|
});
|
|
|
|
// let this user know who else is already present in the room
|
|
try {
|
|
const socketIds = await io.in(room).allSockets();
|
|
|
|
// because a single user can have multiple socket connections we
|
|
// need to make sure that only unique userIds are returned. A Map
|
|
// makes this easy.
|
|
const userIds = new Map();
|
|
|
|
for (const socketId of socketIds) {
|
|
const userId = await Redis.defaultClient.hget(socketId, "userId");
|
|
userIds.set(userId, userId);
|
|
}
|
|
|
|
socket.emit("document.presence", {
|
|
documentId: event.documentId,
|
|
userIds: Array.from(userIds.keys()),
|
|
editingIds: editing.map((view) => view.userId),
|
|
});
|
|
} catch (err) {
|
|
if (err) {
|
|
Logger.error("Error getting clients for room", err);
|
|
return;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
});
|
|
|
|
// allow the client to request to leave rooms
|
|
socket.on("leave", async (event) => {
|
|
if (event.collectionId) {
|
|
await socket.leave(`collection-${event.collectionId}`);
|
|
Metrics.increment("websockets.collections.leave");
|
|
}
|
|
|
|
if (event.documentId) {
|
|
const room = `document-${event.documentId}`;
|
|
|
|
await socket.leave(room);
|
|
Metrics.increment("websockets.documents.leave");
|
|
io.to(room).emit("user.leave", {
|
|
userId: user.id,
|
|
documentId: event.documentId,
|
|
});
|
|
}
|
|
});
|
|
|
|
socket.on("disconnecting", () => {
|
|
socket.rooms.forEach((room) => {
|
|
if (room.startsWith("document-")) {
|
|
const documentId = room.replace("document-", "");
|
|
io.to(room).emit("user.leave", {
|
|
userId: user.id,
|
|
documentId,
|
|
});
|
|
}
|
|
});
|
|
});
|
|
|
|
socket.on("presence", async (event) => {
|
|
Metrics.increment("websockets.presence");
|
|
const room = `document-${event.documentId}`;
|
|
|
|
if (event.documentId && socket.rooms.has(room)) {
|
|
const view = await View.touch(event.documentId, user.id, event.isEditing);
|
|
|
|
view.user = user;
|
|
io.to(room).emit("user.presence", {
|
|
userId: user.id,
|
|
documentId: event.documentId,
|
|
isEditing: event.isEditing,
|
|
});
|
|
|
|
socket.on("typing", async (event) => {
|
|
const room = `document-${event.documentId}`;
|
|
|
|
if (event.documentId && socket.rooms[room]) {
|
|
io.to(room).emit("user.typing", {
|
|
userId: user.id,
|
|
documentId: event.documentId,
|
|
commentId: event.commentId,
|
|
});
|
|
}
|
|
});
|
|
}
|
|
});
|
|
}
|
|
|
|
/**
|
|
* Authenticate the socket with the given token, attach the user model for the
|
|
* duration of the session.
|
|
*/
|
|
async function authenticate(socket: SocketWithAuth, data: { token: string }) {
|
|
const { token } = data;
|
|
|
|
const user = await getUserForJWT(token);
|
|
socket.client.user = user;
|
|
|
|
// store the mapping between socket id and user id in redis so that it is
|
|
// accessible across multiple websocket servers. Lasts 24 hours, if they have
|
|
// a websocket connection that lasts this long then well done.
|
|
await Redis.defaultClient.hset(socket.id, "userId", user.id);
|
|
await Redis.defaultClient.expire(socket.id, 3600 * 24);
|
|
}
|