* Webhooks (#3607) * Get the migration and the model setup. Also make the sample env file a bit easier to use. Now just requires setting a SECRET_KEY and besides that will boot up from the sample * WIP: Start getting a Webhook page created. Just the skeleton state right now * WIP: Getting a form created to create webhooks, need to bring in react-hook-forms now * WIP: Get library installed and make TS happy * Get a few checkboxes ready to go * Get creating and destroying working with a decent start to a frontend * Didn't mean to enable this * Remove eslint and fix other random typescript issue * Rename some events to be more realistic * Revert these changes * PR review comments around policies. Also make sure this inherits from IdModel so it actually gets an id * Allow any admin on the team to edit webhooks * Start sending some webhooks for some User events * Make sure the URL is valid * Start recording webhook deliveries * Make sure to verify if the subscription is for the type of event we are looking at * Refactor sending Webhooks and follow better webhook schema This creates a presenter to unify the format of webhooks. We also extract the sending of webhooks and recording their deliveries to a method than can be used by each of the different event type methods We also add a status to WebhookDelivery since we need to save the record before we make the HTTP request to get its id. Then once we make the request and get a response we can update the delivery with the HTTP info * Turn off a subscription that has failed for the last 25 deliveries * Get a first spec passing. Found a bug in my returning of promises so good to patch that up now * This looks nicer * Get some tests added for the processor * Add cron task to delete older webhooks * Add Document Events to the Processor * Revisions, FileOperations and Collections * Get all the server side events added to the processor and make Typescript make sure they are all accounted for * Get all the events added to the Frontend and work on styling them a bit, still needs some love though * Get UI styled up a bit * Get events wired up for webhook subscriptions * Get delete events working and test at least one variant of them * Get deletes working and actually make sure to send the model id in the webhook * Remove webhook secrets from this slice * Add disabled label for subscriptions that are disabled * Make sure to cascade the delete * Reorg this file a bit * Fix association * I removed secret for the moment * Apply Copy changes from PR Review Co-authored-by: Tom Moor <tom.moor@gmail.com> * Actually apply the copy changes TIL that if you Resolve a conversation it _also_ removes the 'staged suggestion' from your list on Github Co-authored-by: Tom Moor <tom.moor@gmail.com> * Update app/scenes/Settings/Webhooks.tsx Missed this copy change before Co-authored-by: Tom Moor <tom.moor@gmail.com> * Add disabled as yellow badge * Resolve frontend comments * Fixup Schema a bit and remove the dependency on the subscription * Add test to make sure we don't disable until there are enough failures, and fix code to actually do that. Also some test fixes from the json response shape changes * Fix WebhookDeliveries to store the responses as Text instead of blobs * Switch to text better for response bodies, this is using the helpers better and makes the code read better * Move the logic to a task but run in through the processor cause the tests expect that right now, moving the tests over next * Split up the tests and actually enqueue the events from the WebhookProcessor instead of doing them inline * Allow any team admin to see any webhook subscription for the team * Add the indexes based on our lookup patterns * Run eslint --fix to fix auto correct issues from when I tried to use Github to merge copy changes * Allow subscriptions to be edited after creation * Types caught that I didn't add the new event to the webhook processor, also added it to the frontend here * I think this will get these into the translations file * Catch a few more translations, use styled components better and remove usage of webhook subscription in the copy Co-authored-by: Tom Moor <tom.moor@gmail.com> * fix: tsc fix: Document model payload empty * fix: Revision webhook payload Add custom UA for hooks * Add webhooks icon, move under Integrations settings Some spacing fixes * Add actorId to webhook payloads * Add View and ApiKey event types * Spacing tweaks, fix team payload * fix: Webhook not disabled after 25 failures * fix: Enable webhook when editing if previously disabled * fix: Correctly store response headers * fix: Error in json/parsing/presentation results in hanging 'pending' webhook delivery * fix: Awkward payload for users.invite webhook * Add BaseEvent, ShareEvent * fix: Add share events to form * fix: Move webhook delivery cleanup to single DB call Remove some unused abstraction * Add user, collection, group context to membership webhook events Some associated refactoring Co-authored-by: Corey Alexander <coreyja@gmail.com>
285 lines
6.9 KiB
TypeScript
285 lines
6.9 KiB
TypeScript
import { isEqual, filter, includes } from "lodash";
|
|
import * as React from "react";
|
|
import { useEffect } from "react";
|
|
import { useForm } from "react-hook-form";
|
|
import { useTranslation, Trans } from "react-i18next";
|
|
import styled from "styled-components";
|
|
import WebhookSubscription from "~/models/WebhookSubscription";
|
|
import Button from "~/components/Button";
|
|
import { ReactHookWrappedInput } from "~/components/Input";
|
|
import Text from "~/components/Text";
|
|
import useMobile from "~/hooks/useMobile";
|
|
|
|
const WEBHOOK_EVENTS = {
|
|
user: [
|
|
"users.create",
|
|
"users.signin",
|
|
"users.update",
|
|
"users.suspend",
|
|
"users.activate",
|
|
"users.delete",
|
|
"users.invite",
|
|
],
|
|
document: [
|
|
"documents.create",
|
|
"documents.publish",
|
|
"documents.unpublish",
|
|
"documents.delete",
|
|
"documents.permanent_delete",
|
|
"documents.archive",
|
|
"documents.unarchive",
|
|
"documents.restore",
|
|
"documents.star",
|
|
"documents.unstar",
|
|
"documents.move",
|
|
"documents.update",
|
|
"documents.update.delayed",
|
|
"documents.update.debounced",
|
|
"documents.title_change",
|
|
],
|
|
revision: ["revisions.create"],
|
|
fileOperation: [
|
|
"file_operations.create",
|
|
"file_operations.update",
|
|
"file_operations.delete",
|
|
],
|
|
collection: [
|
|
"collections.create",
|
|
"collections.update",
|
|
"collections.delete",
|
|
"collections.add_user",
|
|
"collections.remove_user",
|
|
"collections.add_group",
|
|
"collections.remove_group",
|
|
"collections.move",
|
|
"collections.permission_changed",
|
|
],
|
|
group: [
|
|
"groups.create",
|
|
"groups.update",
|
|
"groups.delete",
|
|
"groups.add_user",
|
|
"groups.remove_user",
|
|
],
|
|
integration: ["integrations.create", "integrations.update"],
|
|
share: ["shares.create", "shares.update", "shares.revoke"],
|
|
team: ["teams.update"],
|
|
pin: ["pins.create", "pins.update", "pins.delete"],
|
|
webhookSubscription: [
|
|
"webhook_subscriptions.create",
|
|
"webhook_subscriptions.delete",
|
|
"webhook_subscriptions.update",
|
|
],
|
|
view: ["views.create"],
|
|
};
|
|
|
|
const EventCheckboxLabel = styled.label`
|
|
display: flex;
|
|
align-items: center;
|
|
font-size: 15px;
|
|
padding: 0.2em 0;
|
|
`;
|
|
|
|
const GroupEventCheckboxLabel = styled(EventCheckboxLabel)`
|
|
font-weight: 500;
|
|
font-size: 1.2em;
|
|
`;
|
|
|
|
const AllEventCheckboxLabel = styled(GroupEventCheckboxLabel)`
|
|
font-size: 1.4em;
|
|
`;
|
|
|
|
const EventCheckboxText = styled.span`
|
|
margin-left: 0.5rem;
|
|
`;
|
|
|
|
interface FieldProps {
|
|
disabled?: boolean;
|
|
}
|
|
const FieldSet = styled.fieldset<FieldProps>`
|
|
padding: 0;
|
|
margin: 0;
|
|
border: none;
|
|
|
|
${({ disabled }) =>
|
|
disabled &&
|
|
`
|
|
opacity: 0.5;
|
|
`}
|
|
`;
|
|
|
|
interface MobileProps {
|
|
isMobile?: boolean;
|
|
}
|
|
const GroupGrid = styled.div<MobileProps>`
|
|
display: grid;
|
|
grid-template-columns: 1fr 1fr;
|
|
|
|
${({ isMobile }) =>
|
|
isMobile &&
|
|
`
|
|
grid-template-columns: 1fr;
|
|
`}
|
|
`;
|
|
|
|
const GroupWrapper = styled.div<MobileProps>`
|
|
padding-bottom: 2rem;
|
|
|
|
${({ isMobile }) =>
|
|
isMobile &&
|
|
`
|
|
padding-bottom: 1rem;
|
|
`}
|
|
`;
|
|
|
|
const TextFields = styled.div`
|
|
display: flex;
|
|
flex-direction: column;
|
|
margin-bottom: 1em;
|
|
`;
|
|
|
|
type Props = {
|
|
handleSubmit: (data: FormData) => void;
|
|
webhookSubscription?: WebhookSubscription;
|
|
};
|
|
|
|
interface FormData {
|
|
name: string;
|
|
url: string;
|
|
events: string[];
|
|
}
|
|
|
|
function WebhookSubscriptionForm({ handleSubmit, webhookSubscription }: Props) {
|
|
const { t } = useTranslation();
|
|
const {
|
|
register,
|
|
handleSubmit: formHandleSubmit,
|
|
formState,
|
|
watch,
|
|
setValue,
|
|
} = useForm<FormData>({
|
|
mode: "all",
|
|
defaultValues: {
|
|
events: webhookSubscription ? [...webhookSubscription.events] : [],
|
|
name: webhookSubscription?.name,
|
|
url: webhookSubscription?.url,
|
|
},
|
|
});
|
|
|
|
const events = watch("events");
|
|
const selectedGroups = filter(events, (e) => !e.includes("."));
|
|
const isAllEventSelected = includes(events, "*");
|
|
const filteredEvents = filter(events, (e) => {
|
|
const [beforePeriod] = e.split(".");
|
|
|
|
return (
|
|
selectedGroups.length === 0 ||
|
|
e === beforePeriod ||
|
|
!selectedGroups.includes(beforePeriod)
|
|
);
|
|
});
|
|
|
|
const isMobile = useMobile();
|
|
|
|
useEffect(() => {
|
|
if (isAllEventSelected) {
|
|
setValue("events", ["*"]);
|
|
}
|
|
}, [isAllEventSelected, setValue]);
|
|
|
|
useEffect(() => {
|
|
if (!isEqual(events, filteredEvents)) {
|
|
setValue("events", filteredEvents);
|
|
}
|
|
}, [events, filteredEvents, setValue]);
|
|
|
|
const verb = webhookSubscription ? t("Update") : t("Create");
|
|
const inProgressVerb = webhookSubscription ? t("Updating") : t("Creating");
|
|
|
|
function EventCheckbox({ label, value }: { label: string; value: string }) {
|
|
const LabelComponent =
|
|
value === "*"
|
|
? AllEventCheckboxLabel
|
|
: Object.keys(WEBHOOK_EVENTS).includes(value)
|
|
? GroupEventCheckboxLabel
|
|
: EventCheckboxLabel;
|
|
|
|
return (
|
|
<LabelComponent>
|
|
<input
|
|
type="checkbox"
|
|
defaultValue={value}
|
|
{...register("events", {})}
|
|
/>
|
|
<EventCheckboxText>{label}</EventCheckboxText>
|
|
</LabelComponent>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<form onSubmit={formHandleSubmit(handleSubmit)}>
|
|
<Text type="secondary">
|
|
<Trans>
|
|
Provide a descriptive name for this webhook and the URL we should send
|
|
a POST request to when matching events are created.
|
|
</Trans>
|
|
</Text>
|
|
<Text type="secondary">
|
|
<Trans>
|
|
Subscribe to all events, groups, or individual events. We recommend
|
|
only subscribing to the minimum amount of events that your application
|
|
needs to function.
|
|
</Trans>
|
|
</Text>
|
|
<TextFields>
|
|
<ReactHookWrappedInput
|
|
required
|
|
autoFocus
|
|
flex
|
|
label={t("Name")}
|
|
{...register("name", {
|
|
required: true,
|
|
})}
|
|
/>
|
|
<ReactHookWrappedInput
|
|
required
|
|
autoFocus
|
|
flex
|
|
pattern="https://.*"
|
|
placeholder="https://…"
|
|
label={t("URL")}
|
|
{...register("url", { required: true })}
|
|
/>
|
|
</TextFields>
|
|
|
|
<EventCheckbox label={t("All events")} value="*" />
|
|
|
|
<FieldSet disabled={isAllEventSelected}>
|
|
<GroupGrid isMobile={isMobile}>
|
|
{Object.entries(WEBHOOK_EVENTS).map(([group, events], i) => (
|
|
<GroupWrapper key={i} isMobile={isMobile}>
|
|
<EventCheckbox
|
|
label={t(`All {{ groupName }} events`, { groupName: group })}
|
|
value={group}
|
|
/>
|
|
<FieldSet disabled={selectedGroups.includes(group)}>
|
|
{events.map((event) => (
|
|
<EventCheckbox label={event} value={event} key={event} />
|
|
))}
|
|
</FieldSet>
|
|
</GroupWrapper>
|
|
))}
|
|
</GroupGrid>
|
|
</FieldSet>
|
|
<Button
|
|
type="submit"
|
|
disabled={formState.isSubmitting || !formState.isValid}
|
|
>
|
|
{formState.isSubmitting ? `${inProgressVerb}…` : verb}
|
|
</Button>
|
|
</form>
|
|
);
|
|
}
|
|
|
|
export default WebhookSubscriptionForm;
|