* change the api of domain parsing to just parseDomain and getCookieDomain
* adds getBaseDomain as the method to get the domain after any official subdomains
* Allow Document to be fetched without Slug
Fixes#3423
This PR refactors the `Document.findByPk` method to not require the
`slug` portion of the urlID.
Before this function accepted two different 'formats' for the ID.
- The `uuid` ID of the Document
- The full `urlID` which looked something like
`some-document-1234567890`
However the `some-document` slug portion of this identifier wasn't
actually used when looking for a document.
We now allow searching by JUST the postfix of the `urlID`, in the above
example that is `1234567890`.
We do this via a new Regex pattern to match on that just looks for the
right looking id alone, without the prefix.
This codepath looks the same as when we find it by the full `urlID`
besides the different regex that we match on.
The issue #3423 mentions that this should apply to all the API
endpoints. I believe that this `findByPk` method is all that should be
needed for that change. But if this is incorrect, OR you would like more
test coverage on the API endpoints as a more 'end to end test' please
let me know!
* Change original regex to make the slug optional
This has the, I believe to be good, side-effect of making the same logic
apply to `Collection` as well. Since `Collection` was always doing the
same stripping of the slug before the lookup I believe it should be just
as safe to do there.
We don't have to touch the code in Collections but we add a test of this
behavior there as well.
* No reason to rename this now that we aren't doing two matches
Remove menu hover styles on mobile
Fixed duplicate hover+active behavior on editor menus
Fixed editor menus visibly scroll to the top when reopened
Fixed some minor editor spacing issues
Renamed shred routeHelpers -> urlHelpers
This PR moves the entire project to Typescript. Due to the ~1000 ignores this will lead to a messy codebase for a while, but the churn is worth it – all of those ignore comments are places that were never type-safe previously.
closes#1282
* core search logic
* bump version of rich markdown editor
* let shift and meta modifiers do their thing when clicking on a link in a doc
* version bump editor
* test: Add parseDocumentSlug test
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* feat: Move to React.lazy
* perf: Remove duplicate babel/runtime
* fix: Run yarn-deduplicate
* Further attempts to remove rich-markdown-editor from initial chunk
* perf: Lazy loading of authenticated routes
* perf: Move color picker to async loading
fix: Display placeholder when loading rich editor
* fix: Cache bust on auto reload
* stash
* refactor
* refactor, styling
* tweaks
* pointer
* styling
* fi: Hide when printing
* fix: No hover cards on shared links
* remove suppressions no longer needed
* fix: Don't show hover cards when editing, they get in the way
* fix: Prevent hover card from going off rhs edge of screen
* fix: Remount hover card when changing between links
* fix: allow one part domains in links (#1350)
* allow one part domains in links
* no TLD when only one part domain
* return null for parseDomain of empty string
* fix fiddly hover preview behavior
* WIP
* refactor hover preview
* fix: Non-rounded bottom corners
* fix: Fixes an edgecase where mounting the nested editor in hovercard causesdocument to scroll if there is a hash in the url
* fix: Incorrect document preview rendering
* lint
Co-authored-by: Nan Yu <thenanyu@gmail.com>
Co-authored-by: Nan Yu <nan@getoutline.com>
* fix: Don't set cookie domain when not using multiple subdomains
* wip logging domain
* wip logging domain
* wip logging domain
* wip logging domain
* Revert "wip logging domain"
This reverts commit 325907e74962179e02cee0b1df364a3aedbe62e3.
* Revert "wip logging domain"
This reverts commit 6ee095a49e9c18999a20d5379234323d49d5e6c8.
* Revert "wip logging domain"
This reverts commit 813d8eb960cdf4dd6db4795739df3adf895600e2.
* Revert "wip logging domain"
This reverts commit f1ca81927626bbd0d46c1963510d115a003176d8.
* Remove SUBDOMAINS_ENABLED from documented env variables, no-one self hosting should need this – it just adds confusion to those looking to host on a single subdomain
fix: Account for server/client process.env parsing
Co-authored-by: Nan Yu <nanyu@Nans-MBP-2.lan>
Co-authored-by: Nan Yu <nan@getoutline.com>
* WIP - got one API test to pass yay
* adds group update endpoint
* added group policies
* adds groups.list API
* adds groups.info
* remove comment
* WIP
* tests for delete
* adds group membership list
* adds tests for groups list
* add and remove user endpoints for group
* ask some questions
* fix up some issues around primary keys
* remove export from group permissions
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* remove random file
* only create events on actual updates, add tests to ensure
* adds uniqueness validation to group name
* throw validation errors on model and let it pass through the controller
* fix linting
* WIP
* WIP
* WIP
* WIP
* WIP basic edit and delete
* basic CRUD for groups and memberships in place
* got member counts working
* add member count and limit the number of users sent over teh wire to 6
* factor avatar with AvatarWithPresence into its own class
* wip
* WIP avatars in group lists
* WIP collection groups
* add and remove group endpoints
* wip add collection groups
* wip get group adding to collections to work
* wip get updating collection group memberships to work
* wip get new group modal working
* add tests for collection index
* include collection groups in the withmemberships scope
* tie permissions to group memberships
* remove unused import
* Update app/components/GroupListItem.js
update title copy
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update server/migrations/20191211044318-create-groups.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update server/api/groups.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update server/api/groups.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/menus/CollectionMenu.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update server/models/Group.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* minor fixes
* Update app/scenes/CollectionMembers/AddGroupsToCollection.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/menus/GroupMenu.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/menus/GroupMenu.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/menus/GroupMenu.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/scenes/Collection.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/scenes/CollectionMembers/CollectionMembers.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/scenes/GroupNew.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/scenes/GroupNew.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/scenes/Settings/Groups.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update server/api/documents.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/scenes/CollectionMembers/components/CollectionGroupMemberListItem.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* address comments
* WIP - getting websocket stuff up and running
* socket event for group deletion
* wrapped up cascading deletes
* lint
* flow
* fix: UI feedback
* fix: Facepile size
* fix: Lots of missing await's
* Allow clicking facepile on group list item to open members
* remove unused route push, grammar
* fix: Remove bad analytics events
feat: Add group events to audit log
* collection. -> collections.
* Add groups to entity websocket events (sync create/update/delete) between clients
* fix: Users should not be able to see groups they are not a member of
* fix: Not caching errors in UI when changing group memberships
* fix: Hide unusable UI
* test
* fix: Tweak language
* feat: Automatically open 'add member' modal after creating group
Co-authored-by: Tom Moor <tom.moor@gmail.com>
