* Improve types
* More types, fix default permission for viewers added to collection
* fix change of default role for CollectionGroup
* Restore policy
* test
* tests
* Webhooks (#3607)
* Get the migration and the model setup. Also make the sample env file a bit easier to use. Now just requires setting a SECRET_KEY and besides that will boot up from the sample
* WIP: Start getting a Webhook page created. Just the skeleton state right now
* WIP: Getting a form created to create webhooks, need to bring in react-hook-forms now
* WIP: Get library installed and make TS happy
* Get a few checkboxes ready to go
* Get creating and destroying working with a decent start to a frontend
* Didn't mean to enable this
* Remove eslint and fix other random typescript issue
* Rename some events to be more realistic
* Revert these changes
* PR review comments around policies. Also make sure this inherits from IdModel so it actually gets an id
* Allow any admin on the team to edit webhooks
* Start sending some webhooks for some User events
* Make sure the URL is valid
* Start recording webhook deliveries
* Make sure to verify if the subscription is for the type of event we are looking at
* Refactor sending Webhooks and follow better webhook schema
This creates a presenter to unify the format of webhooks. We also
extract the sending of webhooks and recording their deliveries to a
method than can be used by each of the different event type methods
We also add a status to WebhookDelivery since we need to save the record
before we make the HTTP request to get its id. Then once we make the
request and get a response we can update the delivery with the HTTP info
* Turn off a subscription that has failed for the last 25 deliveries
* Get a first spec passing. Found a bug in my returning of promises so good to patch that up now
* This looks nicer
* Get some tests added for the processor
* Add cron task to delete older webhooks
* Add Document Events to the Processor
* Revisions, FileOperations and Collections
* Get all the server side events added to the processor and make Typescript make sure they are all accounted for
* Get all the events added to the Frontend and work on styling them a bit, still needs some love though
* Get UI styled up a bit
* Get events wired up for webhook subscriptions
* Get delete events working and test at least one variant of them
* Get deletes working and actually make sure to send the model id in the webhook
* Remove webhook secrets from this slice
* Add disabled label for subscriptions that are disabled
* Make sure to cascade the delete
* Reorg this file a bit
* Fix association
* I removed secret for the moment
* Apply Copy changes from PR Review
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* Actually apply the copy changes
TIL that if you Resolve a conversation it _also_ removes the 'staged suggestion' from your list on Github
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* Update app/scenes/Settings/Webhooks.tsx
Missed this copy change before
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* Add disabled as yellow badge
* Resolve frontend comments
* Fixup Schema a bit and remove the dependency on the subscription
* Add test to make sure we don't disable until there are enough failures, and fix code to actually do that. Also some test fixes from the json response shape changes
* Fix WebhookDeliveries to store the responses as Text instead of blobs
* Switch to text better for response bodies, this is using the helpers better and makes the code read better
* Move the logic to a task but run in through the processor cause the tests expect that right now, moving the tests over next
* Split up the tests and actually enqueue the events from the WebhookProcessor instead of doing them inline
* Allow any team admin to see any webhook subscription for the team
* Add the indexes based on our lookup patterns
* Run eslint --fix to fix auto correct issues from when I tried to use Github to merge copy changes
* Allow subscriptions to be edited after creation
* Types caught that I didn't add the new event to the webhook processor, also added it to the frontend here
* I think this will get these into the translations file
* Catch a few more translations, use styled components better and remove usage of webhook subscription in the copy
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* fix: tsc
fix: Document model payload empty
* fix: Revision webhook payload
Add custom UA for hooks
* Add webhooks icon, move under Integrations settings
Some spacing fixes
* Add actorId to webhook payloads
* Add View and ApiKey event types
* Spacing tweaks, fix team payload
* fix: Webhook not disabled after 25 failures
* fix: Enable webhook when editing if previously disabled
* fix: Correctly store response headers
* fix: Error in json/parsing/presentation results in hanging 'pending' webhook delivery
* fix: Awkward payload for users.invite webhook
* Add BaseEvent, ShareEvent
* fix: Add share events to form
* fix: Move webhook delivery cleanup to single DB call
Remove some unused abstraction
* Add user, collection, group context to membership webhook events
Some associated refactoring
Co-authored-by: Corey Alexander <coreyja@gmail.com>
* Migrations, models, commands
* ui
* Move starred hint to location state
* lint
* tsc
* refactor
* Add collection empty state in expanded sidebar
* Add empty placeholder within starred collections
* Drag and drop improves, Relative refactor
* fix: Starring untitled draft leaves empty space
* fix: Creating draft in starred collection shouldnt open main
* fix: Dupe drop cursor
* Final fixes
* fix: Canonical redirect replaces starred location state
* fix: Don't show reorder cursor at the top of collection with no permission to edit when dragging
This PR moves the entire project to Typescript. Due to the ~1000 ignores this will lead to a messy codebase for a while, but the churn is worth it – all of those ignore comments are places that were never type-safe previously.
closes#1282
* updated readme to give some light testing instructions
* updated tests to accept new behavior for group memberships
* use test factories in more places
* add debug logs for mailer events in development
* Make request only when popover is visible
* Update policies required for shares.create shares.update
* Create withCollection scope
* Remove team share check from shares.create
* Update tests
* fix: Publish button disabled on drafts in read-only mode
fix: Template selector appears on edited documents
* fix: Save button does not immediately come available when selecting a template
* fix: Template menu item alignment
closes#2204
* fixes: Use policy for display of star in document title
closes#2354
* fix: Modified time is sometimes bold when last edited user is current user
closes#2355
* fix: Allow starring of drafts
* Align false conditions before true
* Update documents.delete endpoint for permanent delete
* Add permanent delete to events table and integrate with socket.io
* Add permanent delete to document menu
* Update parentDocumentId of direct child to null
* Add translation
* Add test for permanent delete
* Add space
* Update app/scenes/DocumentPermanentDelete.js
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* Update app/stores/DocumentsStore.js
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* Update server/commands/documentPermanentDeleter.js
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* Update app/scenes/DocumentPermanentDelete.js
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* Change socket room from team to collection
* Add translation
* Create log func for commands
* Move tests from utils to permanentDeleter command
* Add additional tests
* Set redirect to trash
* Return promise from beforeEach
* Add undeleted documents validation
* Include deleteAt attribute in db query
* Update server/commands/documentPermanentDeleter.js
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* tweak language
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* Introduce isViewer field
* Update policies
* Make users read-only feature
* Remove not demoting current user validation
* Update tests
* Catch the unhandled promise rejection
* Hide unnecessary ui elements for read-only user
* Update app/scenes/Settings/People.js
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* Remove redundant logic for admin only policies
* Use can logic
* Update snapshot
* Remove lint error
* Update snapshot
* Minor fix
* Update app/menus/UserMenu.js
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* Update server/api/users.js
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* Update app/components/DocumentListItem.js
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* Update app/stores/UsersStore.js
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* Use useCurrentTeam hook in functional component
* Update translation
* Update ternary
* Remove punctuation
* Move the functions to User model
* Update share policy and shareMenu
* Rename makeAdmin to promote
* Create updateCounts function and Rank enum
* Update tests
* Remove enum
* Use async await, remove enum and create computed accessor
* Remove unused variable
* Fix lint issues
* Hide templates
* Create shared/types and use rank type from it
* Delete shared/utils/rank type file
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* feat: Added ability to disable sharing at collection
* fix: Disable all previous share links when disabling collection share
Language
* fix: Disable document sharing for read-only collection members
* wip
* test
* fix: Clear policies after updating sharing settings
* chore: Less ambiguous language
* feat: Allow setting sharing choice on collection creation
- Allow template move in document policy
- fix: Ensure that document is not added to collection structure in documentMover command
- fix: Moving a template should now show nested documents as options
- fix: Hitting 'm' should not allow moving a draft
- fix: Styling of seperators on move screen
