* Webhooks (#3607)
* Get the migration and the model setup. Also make the sample env file a bit easier to use. Now just requires setting a SECRET_KEY and besides that will boot up from the sample
* WIP: Start getting a Webhook page created. Just the skeleton state right now
* WIP: Getting a form created to create webhooks, need to bring in react-hook-forms now
* WIP: Get library installed and make TS happy
* Get a few checkboxes ready to go
* Get creating and destroying working with a decent start to a frontend
* Didn't mean to enable this
* Remove eslint and fix other random typescript issue
* Rename some events to be more realistic
* Revert these changes
* PR review comments around policies. Also make sure this inherits from IdModel so it actually gets an id
* Allow any admin on the team to edit webhooks
* Start sending some webhooks for some User events
* Make sure the URL is valid
* Start recording webhook deliveries
* Make sure to verify if the subscription is for the type of event we are looking at
* Refactor sending Webhooks and follow better webhook schema
This creates a presenter to unify the format of webhooks. We also
extract the sending of webhooks and recording their deliveries to a
method than can be used by each of the different event type methods
We also add a status to WebhookDelivery since we need to save the record
before we make the HTTP request to get its id. Then once we make the
request and get a response we can update the delivery with the HTTP info
* Turn off a subscription that has failed for the last 25 deliveries
* Get a first spec passing. Found a bug in my returning of promises so good to patch that up now
* This looks nicer
* Get some tests added for the processor
* Add cron task to delete older webhooks
* Add Document Events to the Processor
* Revisions, FileOperations and Collections
* Get all the server side events added to the processor and make Typescript make sure they are all accounted for
* Get all the events added to the Frontend and work on styling them a bit, still needs some love though
* Get UI styled up a bit
* Get events wired up for webhook subscriptions
* Get delete events working and test at least one variant of them
* Get deletes working and actually make sure to send the model id in the webhook
* Remove webhook secrets from this slice
* Add disabled label for subscriptions that are disabled
* Make sure to cascade the delete
* Reorg this file a bit
* Fix association
* I removed secret for the moment
* Apply Copy changes from PR Review
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* Actually apply the copy changes
TIL that if you Resolve a conversation it _also_ removes the 'staged suggestion' from your list on Github
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* Update app/scenes/Settings/Webhooks.tsx
Missed this copy change before
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* Add disabled as yellow badge
* Resolve frontend comments
* Fixup Schema a bit and remove the dependency on the subscription
* Add test to make sure we don't disable until there are enough failures, and fix code to actually do that. Also some test fixes from the json response shape changes
* Fix WebhookDeliveries to store the responses as Text instead of blobs
* Switch to text better for response bodies, this is using the helpers better and makes the code read better
* Move the logic to a task but run in through the processor cause the tests expect that right now, moving the tests over next
* Split up the tests and actually enqueue the events from the WebhookProcessor instead of doing them inline
* Allow any team admin to see any webhook subscription for the team
* Add the indexes based on our lookup patterns
* Run eslint --fix to fix auto correct issues from when I tried to use Github to merge copy changes
* Allow subscriptions to be edited after creation
* Types caught that I didn't add the new event to the webhook processor, also added it to the frontend here
* I think this will get these into the translations file
* Catch a few more translations, use styled components better and remove usage of webhook subscription in the copy
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* fix: tsc
fix: Document model payload empty
* fix: Revision webhook payload
Add custom UA for hooks
* Add webhooks icon, move under Integrations settings
Some spacing fixes
* Add actorId to webhook payloads
* Add View and ApiKey event types
* Spacing tweaks, fix team payload
* fix: Webhook not disabled after 25 failures
* fix: Enable webhook when editing if previously disabled
* fix: Correctly store response headers
* fix: Error in json/parsing/presentation results in hanging 'pending' webhook delivery
* fix: Awkward payload for users.invite webhook
* Add BaseEvent, ShareEvent
* fix: Add share events to form
* fix: Move webhook delivery cleanup to single DB call
Remove some unused abstraction
* Add user, collection, group context to membership webhook events
Some associated refactoring
Co-authored-by: Corey Alexander <coreyja@gmail.com>
Fixes#3412
Previously the only way to restrict the domains for a Team were with the ALLOWED_DOMAINS environment variable for self hosted instances.
This PR migrates this to be a database backed setting on the Team object. This is done through the creation of a TeamDomain model that is associated with the Team and contains the domain name
This settings is updated on the Security Tab. Here domains can be added or removed from the Team.
On the server side, we take the code paths that previously were using ALLOWED_DOMAINS and switched them to use the Team allowed domains instead
* fix: Team logo shows as white in settings
fix: Team logo doesnt update in sidebar immediately after updating
refactor to ImageUpload component
* text
Remove menu hover styles on mobile
Fixed duplicate hover+active behavior on editor menus
Fixed editor menus visibly scroll to the top when reopened
Fixed some minor editor spacing issues
Renamed shred routeHelpers -> urlHelpers
This PR moves the entire project to Typescript. Due to the ~1000 ignores this will lead to a messy codebase for a while, but the churn is worth it – all of those ignore comments are places that were never type-safe previously.
closes#1282
* fix: Unauthorized request to views.list from shared documents
* Bump dep styled-components
* chore: Normalize 'new' actions in settings area to top right
chore: Add translation hooks to API tokens screen
chore: Move API tokens loading to paginated list
* feat: Add collection iconography and colors to Slack settings page
fix: Use standardized list components
fix: Slack icon size
chore: Convert to translation strings
* fix: Missing translation, convert to Scene
* chore: Migrations
* chore: Add recording of share link views
* feat: Add display of share link accessed date in admin
* translations
* test
* translations, admin pagination
* Migrations
* New from template
* fix: Don't allow public share of template
* chore: Template badges
* fix: Collection active
* feat: New doc button on template list item
* feat: New template menu
* fix: Sorting
* feat: Templates onboarding notice
* fix: New doc button showing on archived/deleted templates
* add migrations
* first pass at API
* feat: Updated share dialog UI
* tests
* test
* styling tweaks
* feat: Show share state on document
* fix: Allow publishing share links for draft docs
* test: shares.info
* WIP - got one API test to pass yay
* adds group update endpoint
* added group policies
* adds groups.list API
* adds groups.info
* remove comment
* WIP
* tests for delete
* adds group membership list
* adds tests for groups list
* add and remove user endpoints for group
* ask some questions
* fix up some issues around primary keys
* remove export from group permissions
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* remove random file
* only create events on actual updates, add tests to ensure
* adds uniqueness validation to group name
* throw validation errors on model and let it pass through the controller
* fix linting
* WIP
* WIP
* WIP
* WIP
* WIP basic edit and delete
* basic CRUD for groups and memberships in place
* got member counts working
* add member count and limit the number of users sent over teh wire to 6
* factor avatar with AvatarWithPresence into its own class
* wip
* WIP avatars in group lists
* WIP collection groups
* add and remove group endpoints
* wip add collection groups
* wip get group adding to collections to work
* wip get updating collection group memberships to work
* wip get new group modal working
* add tests for collection index
* include collection groups in the withmemberships scope
* tie permissions to group memberships
* remove unused import
* Update app/components/GroupListItem.js
update title copy
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update server/migrations/20191211044318-create-groups.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update server/api/groups.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update server/api/groups.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/menus/CollectionMenu.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update server/models/Group.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* minor fixes
* Update app/scenes/CollectionMembers/AddGroupsToCollection.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/menus/GroupMenu.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/menus/GroupMenu.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/menus/GroupMenu.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/scenes/Collection.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/scenes/CollectionMembers/CollectionMembers.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/scenes/GroupNew.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/scenes/GroupNew.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/scenes/Settings/Groups.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update server/api/documents.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* Update app/scenes/CollectionMembers/components/CollectionGroupMemberListItem.js
Co-Authored-By: Tom Moor <tom.moor@gmail.com>
* address comments
* WIP - getting websocket stuff up and running
* socket event for group deletion
* wrapped up cascading deletes
* lint
* flow
* fix: UI feedback
* fix: Facepile size
* fix: Lots of missing await's
* Allow clicking facepile on group list item to open members
* remove unused route push, grammar
* fix: Remove bad analytics events
feat: Add group events to audit log
* collection. -> collections.
* Add groups to entity websocket events (sync create/update/delete) between clients
* fix: Users should not be able to see groups they are not a member of
* fix: Not caching errors in UI when changing group memberships
* fix: Hide unusable UI
* test
* fix: Tweak language
* feat: Automatically open 'add member' modal after creating group
Co-authored-by: Tom Moor <tom.moor@gmail.com>
* save images as private and serve via signed url from images.info api
* download private images to directory on export
* fix lint errors
* private s3 default, AWS.s3 module level scope, default s3 url expiry
* combine regex to one, and only replace when there are matches
* fix lint
* code not needed anymore, remove
* updates after pulling master
* revert the uploadToS3FromUrl url return
* use model gettr to compact code, rename to attachments api
* basic checking of document read permission to allow attachment viewing
* fix: Continue to upload avatars as public
fix: Allow redirect for non-private attachments
* add support for publicly shared documents
* catch errors which crash the app during zip export and user creation
* add tests
* enable AWS signature v4 for s3
* switch to use factories to build models for testing
* add isDocker flag for local serving of attachment redirect url
* fix redirect tests
Co-authored-by: Tom Moor <tom.moor@gmail.com>
