chore: Add eslint rule for no-shadow (#6658)

* chore: Add eslint rule for no-shadow

* fix

shared/editor/components/hooks/useDragResize.ts

@@ -84,7 +84,7 @@ export default function useDragResize(props: Props): ReturnValue {
   };
 
   const handlePointerDown =
-    (dragging: "left" | "right") =>
+    (dragDirection: "left" | "right") =>
     (event: React.PointerEvent<HTMLDivElement>) => {
       event.preventDefault();
       event.stopPropagation();
@@ -93,7 +93,7 @@ export default function useDragResize(props: Props): ReturnValue {
         height: size.height,
       });
       setOffset(event.pageX);
-      setDragging(dragging);
+      setDragging(dragDirection);
     };
 
   React.useEffect(() => {

shared/editor/lib/ExtensionManager.ts

@@ -134,7 +134,7 @@ export default class ExtensionManager {
     plugins,
   }: {
     schema: Schema;
-    rules?: Record<string, any>;
+    rules?: markdownit.Options;
     plugins?: PluginSimple[];
   }): MarkdownParser {
     const tokens = this.extensions

shared/editor/lib/markdown/rules.ts

@@ -1,10 +1,10 @@
 import markdownit, { PluginSimple } from "markdown-it";
 
-export default function rules({
+export default function makeRules({
   rules = {},
   plugins = [],
 }: {
-  rules?: Record<string, any>;
+  rules?: markdownit.Options;
   plugins?: PluginSimple[];
 }) {
   const markdownIt = markdownit("default", {

shared/editor/lib/markdown/serializer.ts

@@ -221,7 +221,7 @@ export class MarkdownSerializerState {
         })
       ) {
         // eslint-disable-next-line @typescript-eslint/no-unused-vars, no-unused-vars
-        const [_, lead, inner, trail] = /^(\s*)(.*?)(\s*)$/m.exec(node.text);
+        const [, lead, inner, trail] = /^(\s*)(.*?)(\s*)$/m.exec(node.text);
         leading += lead;
         trailing = trail;
         if (lead || trail) {
@@ -366,20 +366,20 @@ export class MarkdownSerializerState {
       row.forEach((cell, _, j) => {
         this.out += j === 0 ? "| " : " | ";
 
-        cell.forEach((node) => {
+        cell.forEach((cellNode) => {
           // just padding the output so that empty cells take up the same space
           // as headings.
           // TODO: Ideally we'd calc the longest cell length and use that
           // to pad all the others.
           if (
-            node.textContent === "" &&
-            node.content.size === 0 &&
-            node.type.name === "paragraph"
+            cellNode.textContent === "" &&
+            cellNode.content.size === 0 &&
+            cellNode.type.name === "paragraph"
           ) {
             this.out += "  ";
           } else {
             this.closed = false;
-            this.render(node, row, j);
+            this.render(cellNode, row, j);
           }
         });
 

shared/editor/plugins/Suggestions.ts

@@ -28,11 +28,11 @@ export class SuggestionsMenuPlugin extends Plugin {
             // timeout ensures that the delete has been handled by prosemirror
             // and any characters removed, before we evaluate the rule.
             setTimeout(() => {
-              const { pos } = view.state.selection.$from;
+              const { pos: fromPos } = view.state.selection.$from;
               return this.execute(
                 view,
-                pos,
-                pos,
+                fromPos,
+                fromPos,
                 options.openRegex,
                 action((_, match) => {
                   if (match) {

shared/editor/rules/breaks.ts

@@ -11,7 +11,6 @@ function isHardbreak(token: Token) {
 export default function markdownBreakToParagraphs(md: MarkdownIt) {
   // insert a new rule after the "inline" rules are parsed
   md.core.ruler.after("inline", "breaks", (state) => {
-    const { Token } = state;
     const tokens = state.tokens;
 
     // work backwards through the tokens and find text that looks like a br
@@ -30,8 +29,8 @@ export default function markdownBreakToParagraphs(md: MarkdownIt) {
           count++;
         }
 
-        for (let i = 0; i < count; i++) {
-          const isLast = i === count - 1;
+        for (let j = 0; j < count; j++) {
+          const isLast = j === count - 1;
 
           token = new Token("paragraph_open", "p", 1);
           nodes.push(token);

shared/editor/rules/checkboxes.ts

@@ -56,9 +56,9 @@ export default function markdownItCheckbox(md: MarkdownIt): void {
 
     // work backwards through the tokens and find text that looks like a checkbox
     for (let i = tokens.length - 1; i > 0; i--) {
-      const matches = looksLikeChecklist(tokens, i);
-      if (matches) {
-        const value = matches[1];
+      const matchesChecklist = looksLikeChecklist(tokens, i);
+      if (matchesChecklist) {
+        const value = matchesChecklist[1];
         const checked = value.toLowerCase() === "x";
 
         // convert surrounding list tokens