fix: Improvements in share feat (#2502)

* Make request only when popover is visible

* Update policies required for shares.create shares.update

* Create withCollection scope

* Remove team share check from shares.create

* Update tests
This commit is contained in:
Saumya Pandey
2021-08-29 10:44:09 +05:30
committed by GitHub
parent e4b7aa6761
commit f389ac6414
6 changed files with 85 additions and 15 deletions

View File

@@ -44,6 +44,27 @@ Share.associate = (models) => {
{ association: "team" },
],
});
Share.addScope("withCollection", (userId) => {
return {
include: [
{
model: models.Document,
paranoid: true,
as: "document",
include: [
{
model: models.Collection.scope({
method: ["withMembership", userId],
}),
as: "collection",
},
],
},
{ association: "user", paranoid: false },
{ association: "team" },
],
};
});
};
Share.prototype.revoke = function (userId) {