yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Correctly sanitize href in link editor 'open url' flow

Browse Source
This commit is contained in:
Tom Moor
2022-07-22 00:23:53 +01:00
parent 4b4b0f7037
commit ef2abf824e
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
app/editor/components/LinkEditor.tsx
View File

@@ -44,7 +44,7 @@ type Props = {
href: string, href: string,
event: React.MouseEvent<HTMLButtonElement> event: React.MouseEvent<HTMLButtonElement>
) => void; ) => void;
onShowToast: (message: string, options: ToastOptions) => void; onShowToast: (message: string, options?: ToastOptions) => void;
view: EditorView; view: EditorView;
}; };
@@ -70,7 +70,7 @@ class LinkEditor extends React.Component<Props, State> {
}; };
get href(): string { get href(): string {
return this.props.mark ? this.props.mark.attrs.href : ""; return sanitizeHref(this.props.mark?.attrs.href) ?? "";
} }
get suggestedLinkTitle(): string { get suggestedLinkTitle(): string {
@@ -229,7 +229,12 @@ class LinkEditor extends React.Component<Props, State> {
handleOpenLink = (event: React.MouseEvent<HTMLButtonElement>): void => { handleOpenLink = (event: React.MouseEvent<HTMLButtonElement>): void => {
event.preventDefault(); event.preventDefault();
this.props.onClickLink(this.href, event);
try {
this.props.onClickLink(this.href, event);
} catch (err) {
this.props.onShowToast(this.props.dictionary.openLinkError);
}
}; };
handleCreateLink = async (value: string) => { handleCreateLink = async (value: string) => {