fix: visible groups (#2729)

* updated readme to give some light testing instructions
* updated tests to accept new behavior for group memberships
* use test factories in more places
* add debug logs for mailer events in development
This commit is contained in:
Nan Yu
2021-11-15 16:05:58 -08:00
committed by GitHub
parent 8a76dd49a0
commit ec5e3120d2
6 changed files with 30 additions and 19 deletions

View File

@@ -203,7 +203,7 @@ describe("#groups.info", () => {
expect(body.data.id).toEqual(group.id);
});
it("should not return group if non-member, non-admin", async () => {
it("should still return group if non-member, non-admin", async () => {
const user = await buildUser();
const group = await buildGroup({ teamId: user.teamId });
@@ -211,7 +211,10 @@ describe("#groups.info", () => {
body: { token: user.getJwtToken(), id: group.id },
});
expect(res.status).toEqual(403);
const body = await res.json();
expect(res.status).toEqual(200);
expect(body.data.id).toEqual(group.id);
});
it("should require authentication", async () => {