chore: Test performance (#5786)

plugins/slack/server/api/hooks.test.ts

@@ -152,22 +152,15 @@ describe("#hooks.slack", () => {
       },
     });
 
-    return new Promise((resolve) => {
-      // setTimeout is needed here because SearchQuery is saved asynchronously
-      // in order to not slow down the response time.
-      setTimeout(async () => {
-        const searchQuery = await SearchQuery.findAll({
-          where: {
-            teamId: team.id,
-            query: "contains",
-          },
-        });
-        expect(searchQuery.length).toBe(1);
-        expect(searchQuery[0].results).toBe(0);
-        expect(searchQuery[0].source).toBe("slack");
-        resolve(undefined);
-      }, 250);
+    const searchQuery = await SearchQuery.findAll({
+      where: {
+        teamId: team.id,
+        query: "contains",
+      },
     });
+    expect(searchQuery.length).toBe(1);
+    expect(searchQuery[0].results).toBe(0);
+    expect(searchQuery[0].source).toBe("slack");
   });
 
   it("should respond with help content for help keyword", async () => {

plugins/slack/server/api/hooks.ts

@@ -335,14 +335,12 @@ router.post(
       ? await SearchHelper.searchForUser(user, text, options)
       : await SearchHelper.searchForTeam(team, text, options);
 
-    void SearchQuery.create({
+    await SearchQuery.create({
       userId: user ? user.id : null,
       teamId: team.id,
       source: "slack",
       query: text,
       results: totalCount,
-    }).catch((err) => {
-      Logger.error("Failed to create search query", err);
     });
 
     const haventSignedIn = t(

plugins/webhooks/server/processors/WebhookProcessor.test.ts

@@ -1,5 +1,4 @@
 import { buildUser, buildWebhookSubscription } from "@server/test/factories";
-import { setupTestDatabase } from "@server/test/support";
 import { UserEvent } from "@server/types";
 import DeliverWebhookTask from "../tasks/DeliverWebhookTask";
 import WebhookProcessor from "./WebhookProcessor";
@@ -7,8 +6,6 @@ import WebhookProcessor from "./WebhookProcessor";
 jest.mock("../tasks/DeliverWebhookTask");
 const ip = "127.0.0.1";
 
-setupTestDatabase();
-
 beforeEach(async () => {
   jest.resetAllMocks();
 });

plugins/webhooks/server/tasks/CleanupWebhookDeliveriesTask.test.ts

@@ -1,11 +1,8 @@
 import { subDays } from "date-fns";
 import { WebhookDelivery } from "@server/models";
 import { buildWebhookDelivery } from "@server/test/factories";
-import { setupTestDatabase } from "@server/test/support";
 import CleanupWebhookDeliveriesTask from "./CleanupWebhookDeliveriesTask";
 
-setupTestDatabase();
-
 const deliveryExists = async (delivery: WebhookDelivery) => {
   const results = await WebhookDelivery.findOne({ where: { id: delivery.id } });
   return !!results;

plugins/webhooks/server/tasks/DeliverWebhookTask.test.ts

@@ -6,12 +6,9 @@ import {
   buildWebhookDelivery,
   buildWebhookSubscription,
 } from "@server/test/factories";
-import { setupTestDatabase } from "@server/test/support";
 import { UserEvent } from "@server/types";
 import DeliverWebhookTask from "./DeliverWebhookTask";
 
-setupTestDatabase();
-
 beforeEach(async () => {
   jest.resetAllMocks();
   fetchMock.resetMocks();