Duplicative method cleanup (#6431)

This commit is contained in:
Tom Moor
2024-01-25 20:02:17 -08:00
committed by GitHub
parent cab9a1ec96
commit e62c734c41
13 changed files with 87 additions and 122 deletions

View File

@@ -267,10 +267,10 @@ function CollectionPermissions({ collectionId }: Props) {
<CollectionGroupMemberListItem
key={group.id}
group={group}
collectionGroupMembership={collectionGroupMemberships.find(
collection.id,
group.id
)}
collectionGroupMembership={collectionGroupMemberships.find({
collectionId: collection.id,
groupId: group.id,
})}
onRemove={() => handleRemoveGroup(group)}
onUpdate={(permission) => handleUpdateGroup(group, permission)}
/>
@@ -286,7 +286,10 @@ function CollectionPermissions({ collectionId }: Props) {
<MemberListItem
key={item.id}
user={item}
membership={memberships.find(collection.id, item.id)}
membership={memberships.find({
collectionId: collection.id,
userId: item.id,
})}
canEdit={item.id !== user.id || user.isAdmin}
onRemove={() => handleRemoveUser(item)}
onUpdate={(permission) => handleUpdateUser(item, permission)}

View File

@@ -37,7 +37,7 @@ function TitleDocumentMeta({ to, document, revision, ...rest }: Props) {
const Wrapper = viewsLoadedOnMount.current ? React.Fragment : Fade;
const insightsPath = documentInsightsPath(document);
const commentsCount = comments.inDocument(document.id).length;
const commentsCount = comments.filter({ documentId: document.id }).length;
return (
<Meta document={document} revision={revision} to={to} replace {...rest}>

View File

@@ -22,7 +22,7 @@ function History() {
const document = documents.getByUrl(match.params.documentSlug);
const eventsInDocument = document
? events.inDocument(document.id)
? events.filter({ documentId: document.id })
: EMPTY_ARRAY;
const onCloseHistory = () => {