Assorted cleanup, minor bug fixes, styling fixes, eslint rules (#5165

* fix: Logic error in toast
fix: Remove useless component

* fix: Logout not clearing all stores

* Add icons to notification settings

* Add eslint rule to enforce spaced comment

* Add eslint rule for arrow-body-style

* Add eslint rule to enforce self-closing components

* Add menu to api key settings
Fix: Deleting webhook subscription does not remove from UI
Split webhook subscriptions into active and inactive
Styling updates

server/utils/i18n.ts

@@ -30,8 +30,8 @@ export function initI18n() {
   i18n.use(backend).init({
     compatibilityJSON: "v3",
     backend: {
-      loadPath: (language: string) => {
-        return path.resolve(
+      loadPath: (language: string) =>
+        path.resolve(
           path.join(
             __dirname,
             "..",
@@ -42,8 +42,7 @@ export function initI18n() {
             unicodeBCP47toCLDR(language),
             "translation.json"
           )
-        );
-      },
+        ),
     },
     preload: languages.map(unicodeCLDRtoBCP47),
     interpolation: {

server/utils/opensearch.ts

@@ -1,5 +1,4 @@
-export const opensearchResponse = (baseUrl: string): string => {
-  return `
+export const opensearchResponse = (baseUrl: string): string => `
 <OpenSearchDescription xmlns="http://a9.com/-/spec/opensearch/1.1/" xmlns:moz="http://www.mozilla.org/2006/browser/search/">
   <ShortName>Outline</ShortName>
   <Description>Search Outline</Description>
@@ -9,4 +8,3 @@ export const opensearchResponse = (baseUrl: string): string => {
   <moz:SearchForm>${baseUrl}/search</moz:SearchForm>
 </OpenSearchDescription>
 `;
-};

server/utils/prefetchTags.tsx

@@ -23,14 +23,12 @@ if (isProduction) {
   const returnFileAndImportsFromManifest = (
     manifest: ManifestStructure,
     file: string
-  ): string[] => {
-    return [
-      manifest[file]["file"],
-      ...manifest[file]["imports"].map((entry: string) => {
-        return manifest[entry]["file"];
-      }),
-    ];
-  };
+  ): string[] => [
+    manifest[file]["file"],
+    ...manifest[file]["imports"].map(
+      (entry: string) => manifest[entry]["file"]
+    ),
+  ];
 
   Array.from([
     ...returnFileAndImportsFromManifest(manifest, "app/index.tsx"),

server/utils/s3.ts

@@ -150,14 +150,13 @@ export const uploadToS3FromUrl = async (
   }
 };
 
-export const deleteFromS3 = (key: string) => {
-  return s3
+export const deleteFromS3 = (key: string) =>
+  s3
     .deleteObject({
       Bucket: AWS_S3_UPLOAD_BUCKET_NAME,
       Key: key,
     })
     .promise();
-};
 
 export const getSignedUrl = async (key: string, expiresInMs = 60) => {
   const isDocker = AWS_S3_UPLOAD_BUCKET_URL.match(/http:\/\/s3:/);