Assorted cleanup, minor bug fixes, styling fixes, eslint rules (#5165

* fix: Logic error in toast
fix: Remove useless component

* fix: Logout not clearing all stores

* Add icons to notification settings

* Add eslint rule to enforce spaced comment

* Add eslint rule for arrow-body-style

* Add eslint rule to enforce self-closing components

* Add menu to api key settings
Fix: Deleting webhook subscription does not remove from UI
Split webhook subscriptions into active and inactive
Styling updates

server/routes/api/auth.test.ts

@@ -5,13 +5,11 @@ import { getTestServer } from "@server/test/support";
 
 const mockTeamInSessionId = "1e023d05-951c-41c6-9012-c9fa0402e1c3";
 
-jest.mock("@server/utils/authentication", () => {
-  return {
-    getSessionsInCookie() {
-      return { [mockTeamInSessionId]: {} };
-    },
-  };
-});
+jest.mock("@server/utils/authentication", () => ({
+  getSessionsInCookie() {
+    return { [mockTeamInSessionId]: {} };
+  },
+}));
 
 const server = getTestServer();
 

server/routes/api/collections.ts

@@ -567,16 +567,16 @@ router.post(
     }).findByPk(id);
     authorize(user, "read", collection);
 
-    const fileOperation = await sequelize.transaction(async (transaction) => {
-      return collectionExporter({
+    const fileOperation = await sequelize.transaction(async (transaction) =>
+      collectionExporter({
         collection,
         user,
         team,
         format,
         ip: ctx.request.ip,
         transaction,
-      });
-    });
+      })
+    );
 
     ctx.body = {
       success: true,
@@ -599,15 +599,15 @@ router.post(
 
     assertIn(format, Object.values(FileOperationFormat), "Invalid format");
 
-    const fileOperation = await sequelize.transaction(async (transaction) => {
-      return collectionExporter({
+    const fileOperation = await sequelize.transaction(async (transaction) =>
+      collectionExporter({
         user,
         team,
         format,
         ip: ctx.request.ip,
         transaction,
-      });
-    });
+      })
+    );
 
     ctx.body = {
       success: true,

server/routes/api/documents/documents.ts

@@ -1300,8 +1300,8 @@ router.post(
       authorize(user, "read", templateDocument);
     }
 
-    const document = await sequelize.transaction(async (transaction) => {
-      return documentCreator({
+    const document = await sequelize.transaction(async (transaction) =>
+      documentCreator({
         title,
         text,
         publish,
@@ -1313,8 +1313,8 @@ router.post(
         editorVersion,
         ip: ctx.request.ip,
         transaction,
-      });
-    });
+      })
+    );
 
     document.collection = collection;
 

server/routes/api/teams/teams.ts

@@ -58,12 +58,10 @@ router.post(
     authorize(user, "createTeam", existingTeam);
 
     const authenticationProviders = existingTeam.authenticationProviders.map(
-      (provider) => {
-        return {
-          name: provider.name,
-          providerId: provider.providerId,
-        };
-      }
+      (provider) => ({
+        name: provider.name,
+        providerId: provider.providerId,
+      })
     );
 
     invariant(