Assorted cleanup, minor bug fixes, styling fixes, eslint rules (#5165

* fix: Logic error in toast
fix: Remove useless component

* fix: Logout not clearing all stores

* Add icons to notification settings

* Add eslint rule to enforce spaced comment

* Add eslint rule for arrow-body-style

* Add eslint rule to enforce self-closing components

* Add menu to api key settings
Fix: Deleting webhook subscription does not remove from UI
Split webhook subscriptions into active and inactive
Styling updates

server/commands/teamProvisioner.ts

@@ -106,8 +106,8 @@ async function teamProvisioner({
   }
 
   // We cannot find an existing team, so we create a new one
-  const team = await sequelize.transaction((transaction) => {
-    return teamCreator({
+  const team = await sequelize.transaction((transaction) =>
+    teamCreator({
       name,
       domain,
       subdomain,
@@ -115,8 +115,8 @@ async function teamProvisioner({
       authenticationProviders: [authenticationProvider],
       ip,
       transaction,
-    });
-  });
+    })
+  );
 
   return {
     team,

server/commands/teamUpdater.ts

@@ -115,9 +115,10 @@ const teamUpdater = async ({ params, user, team, ip }: TeamUpdaterProps) => {
       transaction,
     });
     if (changes) {
-      const data = changes.reduce((acc, curr) => {
-        return { ...acc, [curr]: team[curr] };
-      }, {});
+      const data = changes.reduce(
+        (acc, curr) => ({ ...acc, [curr]: team[curr] }),
+        {}
+      );
 
       await Event.create(
         {