Assorted cleanup, minor bug fixes, styling fixes, eslint rules (#5165

* fix: Logic error in toast
fix: Remove useless component

* fix: Logout not clearing all stores

* Add icons to notification settings

* Add eslint rule to enforce spaced comment

* Add eslint rule for arrow-body-style

* Add eslint rule to enforce self-closing components

* Add menu to api key settings
Fix: Deleting webhook subscription does not remove from UI
Split webhook subscriptions into active and inactive
Styling updates

app/utils/ApiClient.ts

@@ -219,17 +219,13 @@ class ApiClient {
     path: string,
     data: Record<string, any> | undefined,
     options?: FetchOptions
-  ) => {
-    return this.fetch(path, "GET", data, options);
-  };
+  ) => this.fetch(path, "GET", data, options);
 
   post = (
     path: string,
     data?: Record<string, any> | undefined,
     options?: FetchOptions
-  ) => {
-    return this.fetch(path, "POST", data, options);
-  };
+  ) => this.fetch(path, "POST", data, options);
 }
 
 export const client = new ApiClient();

app/utils/compressImage.ts

@@ -8,8 +8,7 @@ type Options = {
 export const compressImage = async (
   file: File | Blob,
   options?: Options
-): Promise<Blob> => {
-  return new Promise((resolve, reject) => {
+): Promise<Blob> =>
+  new Promise((resolve, reject) => {
     new Compressor(file, { ...options, success: resolve, error: reject });
   });
-};

app/utils/download.ts

@@ -43,7 +43,7 @@ export default function download(
     return saver(x); // everyone else can save dataURLs un-processed
   }
 
-  //end if dataURL passed?
+  // end if dataURL passed?
   try {
     blob =
       x instanceof B
@@ -81,7 +81,7 @@ export default function download(
       return true;
     }
 
-    //do iframe dataURL download (old ch+FF):
+    // do iframe dataURL download (old ch+FF):
     const f = D.createElement("iframe");
     D.body && D.body.appendChild(f);