Assorted cleanup, minor bug fixes, styling fixes, eslint rules (#5165

* fix: Logic error in toast
fix: Remove useless component

* fix: Logout not clearing all stores

* Add icons to notification settings

* Add eslint rule to enforce spaced comment

* Add eslint rule for arrow-body-style

* Add eslint rule to enforce self-closing components

* Add menu to api key settings
Fix: Deleting webhook subscription does not remove from UI
Split webhook subscriptions into active and inactive
Styling updates

app/editor/index.tsx

@@ -355,8 +355,8 @@ export class Editor extends React.PureComponent<
           decorations: Decoration<{
             [key: string]: any;
           }>[]
-        ) => {
-          return new ComponentView(extension.component, {
+        ) =>
+          new ComponentView(extension.component, {
             editor: this,
             extension,
             node,
@@ -364,7 +364,6 @@ export class Editor extends React.PureComponent<
             getPos,
             decorations,
           });
-        };
 
         return {
           ...nodeViews,
@@ -449,13 +448,12 @@ export class Editor extends React.PureComponent<
       throw new Error("createView called before ref available");
     }
 
-    const isEditingCheckbox = (tr: Transaction) => {
-      return tr.steps.some(
+    const isEditingCheckbox = (tr: Transaction) =>
+      tr.steps.some(
         (step: any) =>
           step.slice?.content?.firstChild?.type.name ===
           this.schema.nodes.checkbox_item.name
       );
-    };
 
     const self = this; // eslint-disable-line
     const view = new EditorView(this.elementRef.current, {
@@ -579,36 +577,28 @@ export class Editor extends React.PureComponent<
    *
    * @returns True if the editor is empty
    */
-  public isEmpty = () => {
-    return ProsemirrorHelper.isEmpty(this.view.state.doc);
-  };
+  public isEmpty = () => ProsemirrorHelper.isEmpty(this.view.state.doc);
 
   /**
    * Return the headings in the current editor.
    *
    * @returns A list of headings in the document
    */
-  public getHeadings = () => {
-    return ProsemirrorHelper.getHeadings(this.view.state.doc);
-  };
+  public getHeadings = () => ProsemirrorHelper.getHeadings(this.view.state.doc);
 
   /**
    * Return the tasks/checkmarks in the current editor.
    *
    * @returns A list of tasks in the document
    */
-  public getTasks = () => {
-    return ProsemirrorHelper.getTasks(this.view.state.doc);
-  };
+  public getTasks = () => ProsemirrorHelper.getTasks(this.view.state.doc);
 
   /**
    * Return the comments in the current editor.
    *
    * @returns A list of comments in the document
    */
-  public getComments = () => {
-    return ProsemirrorHelper.getComments(this.view.state.doc);
-  };
+  public getComments = () => ProsemirrorHelper.getComments(this.view.state.doc);
 
   /**
    * Remove a specific comment mark from the document.
@@ -661,9 +651,9 @@ export class Editor extends React.PureComponent<
       return;
     }
 
-    this.props.onChange((asString = true, trim = false) => {
-      return this.view ? this.value(asString, trim) : undefined;
-    });
+    this.props.onChange((asString = true, trim = false) =>
+      this.view ? this.value(asString, trim) : undefined
+    );
   };
 
   private handleEditorBlur = () => {
@@ -835,13 +825,11 @@ const EditorContainer = styled(Styles)<{ focusedCommentId?: string }>`
 `;
 
 const LazyLoadedEditor = React.forwardRef<Editor, Props>(
-  (props: Props, ref) => {
-    return (
-      <WithTheme>
-        {(theme) => <Editor theme={theme} {...props} ref={ref} />}
-      </WithTheme>
-    );
-  }
+  (props: Props, ref) => (
+    <WithTheme>
+      {(theme) => <Editor theme={theme} {...props} ref={ref} />}
+    </WithTheme>
+  )
 );
 
 export default LazyLoadedEditor;