Assorted cleanup, minor bug fixes, styling fixes, eslint rules (#5165

* fix: Logic error in toast
fix: Remove useless component

* fix: Logout not clearing all stores

* Add icons to notification settings

* Add eslint rule to enforce spaced comment

* Add eslint rule for arrow-body-style

* Add eslint rule to enforce self-closing components

* Add menu to api key settings
Fix: Deleting webhook subscription does not remove from UI
Split webhook subscriptions into active and inactive
Styling updates

app/editor/components/BlockMenu.tsx

@@ -30,7 +30,7 @@ function BlockMenu(props: Props) {
   return (
     <SuggestionsMenu
       {...props}
-      filterable={true}
+      filterable
       onClearSearch={clearSearch}
       renderMenuItem={(item, _index, options) => (
         <SuggestionsMenuItem

app/editor/components/LinkSearchResult.tsx

@@ -25,10 +25,9 @@ function LinkSearchResult({
         scrollIntoView(node, {
           scrollMode: "if-needed",
           block: "center",
-          boundary: (parent) => {
+          boundary: (parent) =>
             // Prevents body and other parent elements from being scrolled
-            return parent !== containerRef.current;
-          },
+            parent !== containerRef.current,
         });
       }
     },

app/editor/components/SuggestionsMenu.tsx

@@ -397,11 +397,9 @@ function SuggestionsMenu<T extends MenuItem>(props: Props<T>) {
     });
 
     return filterExcessSeparators(
-      filtered.sort((item) => {
-        return searchInput && item.title
-          ? commandScore(item.title, searchInput)
-          : 0;
-      })
+      filtered.sort((item) =>
+        searchInput && item.title ? commandScore(item.title, searchInput) : 0
+      )
     );
   }, [commands, props]);
 

app/editor/components/SuggestionsMenuItem.tsx

@@ -28,12 +28,11 @@ function SuggestionsMenuItem({
         scrollIntoView(node, {
           scrollMode: "if-needed",
           block: "nearest",
-          boundary: (parent) => {
+          boundary: (parent) =>
             // All the parent elements of your target are checked until they
             // reach the portal context. Prevents body and other parent
             // elements from being scrolled
-            return parent !== portal;
-          },
+            parent !== portal,
         });
       }
     },