yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: Automatically display errors as toast if uncaught in actions (#6482)

Browse Source 
Reduces plumbing
This commit is contained in:
Tom Moor
2024-02-05 16:40:29 -08:00
committed by GitHub
parent 3a125beb9e
commit d6595c15ad
5 changed files with 44 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
app/components/ActionButton.tsx
View File

@@ -1,6 +1,7 @@
/* eslint-disable react/prop-types */
import * as React from "react";
import Tooltip, { Props as TooltipProps } from "~/components/Tooltip";
import { performAction } from "~/actions";
import { Action, ActionContext } from "~/types";
export type Props = React.HTMLAttributes<HTMLButtonElement> & {
@@ -60,10 +61,10 @@ const ActionButton = React.forwardRef<HTMLButtonElement, Props>(
? (ev) => {
ev.preventDefault();
ev.stopPropagation();
const response = action.perform?.(actionContext);
const response = performAction(action, actionContext);
if (response?.finally) {
setExecuting(true);
response.finally(() => setExecuting(false));
void response.finally(() => setExecuting(false));
}
}
: rest.onClick