Allows commenting outside edit mode when seamless editing is disabled. (#5422)

shared/editor/components/Styles.ts

@@ -578,6 +578,7 @@ h6 {
   border-radius: 2px;
 
   &:hover {
+    ${props.readOnly ? "cursor: var(--pointer);" : ""}
     background: ${transparentize(0.5, props.theme.brand.marine)};
   }
 }

shared/editor/lib/Extension.ts

@@ -41,6 +41,10 @@ export default class Extension {
     return {};
   }
 
+  get allowInReadOnly(): boolean {
+    return false;
+  }
+
   keys(_options: {
     type?: NodeType | MarkType;
     schema: Schema;

shared/editor/lib/ExtensionManager.ts

@@ -205,7 +205,7 @@ export default class ExtensionManager {
           callback: CommandFactory,
           attrs: Record<string, any>
         ) => {
-          if (!view.editable) {
+          if (!view.editable && !extension.allowInReadOnly) {
             return false;
           }
           view.focus();

shared/editor/marks/Comment.ts

@@ -27,6 +27,10 @@ export default class Comment extends Mark {
     };
   }
 
+  get allowInReadOnly() {
+    return true;
+  }
+
   keys({ type }: { type: MarkType }): Record<string, Command> {
     return this.options.onCreateCommentMark
       ? {

shared/editor/types/index.ts

@@ -19,6 +19,7 @@ export type MenuItem = {
   shortcut?: string;
   keywords?: string;
   tooltip?: string;
+  label?: string;
   defaultHidden?: boolean;
   attrs?: Record<string, any>;
   visible?: boolean;