From cffd0be0cfe4fdbf2b05200718adf623b4a1ce76 Mon Sep 17 00:00:00 2001
From: Tom Moor <tom.moor@gmail.com>
Date: Wed, 24 Apr 2024 21:00:01 -0400
Subject: [PATCH] Add missing keyboard shortcuts to guide

---
 app/scenes/KeyboardShortcuts.tsx           | 49 ++++++++++++++++------
 shared/i18n/locales/en_US/translation.json |  7 ++++
 2 files changed, 44 insertions(+), 12 deletions(-)

diff --git a/app/scenes/KeyboardShortcuts.tsx b/app/scenes/KeyboardShortcuts.tsx
index 3e158e793..645e35193 100644
--- a/app/scenes/KeyboardShortcuts.tsx
+++ b/app/scenes/KeyboardShortcuts.tsx
@@ -82,7 +82,7 @@ function KeyboardShortcuts() {
           {
             shortcut: (
               <>
-                <Key symbol>{metaDisplay}</Key> + <Key>Enter</Key>
+                <Key symbol>{metaDisplay}</Key> + <Key>{t("Enter")}</Key>
               </>
             ),
             label: t("Go to link"),
@@ -244,13 +244,13 @@ function KeyboardShortcuts() {
             label: t("Ordered list"),
           },
           {
-            shortcut: <Key>Tab</Key>,
+            shortcut: <Key>{t("Tab")}</Key>,
             label: t("Indent list item"),
           },
           {
             shortcut: (
               <>
-                <Key symbol>⇧</Key> + <Key>Tab</Key>
+                <Key symbol>⇧</Key> + <Key>{t("Tab")}</Key>
               </>
             ),
             label: t("Outdent list item"),
@@ -274,12 +274,37 @@ function KeyboardShortcuts() {
         ],
       },
       {
-        title: "Markdown",
+        title: t("Tables"),
         items: [
           {
             shortcut: (
               <>
-                <Key>#</Key> <Key>Space</Key>
+                <Key symbol>{metaDisplay}</Key> + <Key>{t("Enter")}</Key>
+              </>
+            ),
+            label: t("Insert row"),
+          },
+          {
+            shortcut: <Key>{t("Tab")}</Key>,
+            label: t("Next cell"),
+          },
+          {
+            shortcut: (
+              <>
+                <Key symbol>⇧</Key> + <Key>{t("Tab")}</Key>
+              </>
+            ),
+            label: t("Previous cell"),
+          },
+        ],
+      },
+      {
+        title: t("Markdown"),
+        items: [
+          {
+            shortcut: (
+              <>
+                <Key>#</Key> <Key>{t("Space")}</Key>
               </>
             ),
             label: t("Large header"),
@@ -287,7 +312,7 @@ function KeyboardShortcuts() {
           {
             shortcut: (
               <>
-                <Key>##</Key> <Key>Space</Key>
+                <Key>##</Key> <Key>{t("Space")}</Key>
               </>
             ),
             label: t("Medium header"),
@@ -295,7 +320,7 @@ function KeyboardShortcuts() {
           {
             shortcut: (
               <>
-                <Key>###</Key> <Key>Space</Key>
+                <Key>###</Key> <Key>{t("Space")}</Key>
               </>
             ),
             label: t("Small header"),
@@ -303,7 +328,7 @@ function KeyboardShortcuts() {
           {
             shortcut: (
               <>
-                <Key>1.</Key> <Key>Space</Key>
+                <Key>1.</Key> <Key>{t("Space")}</Key>
               </>
             ),
             label: t("Numbered list"),
@@ -311,7 +336,7 @@ function KeyboardShortcuts() {
           {
             shortcut: (
               <>
-                <Key>-</Key> <Key>Space</Key>
+                <Key>-</Key> <Key>{t("Space")}</Key>
               </>
             ),
             label: t("Bulleted list"),
@@ -319,7 +344,7 @@ function KeyboardShortcuts() {
           {
             shortcut: (
               <>
-                <Key>[ ]</Key> <Key>Space</Key>
+                <Key>[ ]</Key> <Key>{t("Space")}</Key>
               </>
             ),
             label: t("Todo list"),
@@ -327,7 +352,7 @@ function KeyboardShortcuts() {
           {
             shortcut: (
               <>
-                <Key>&gt;</Key> <Key>Space</Key>
+                <Key>&gt;</Key> <Key>{t("Space")}</Key>
               </>
             ),
             label: t("Blockquote"),
@@ -343,7 +368,7 @@ function KeyboardShortcuts() {
           {
             shortcut: (
               <>
-                <Key>$$$</Key> <Key>Space</Key>
+                <Key>$$$</Key> <Key>{t("Space")}</Key>
               </>
             ),
             label: t("LaTeX block"),
diff --git a/shared/i18n/locales/en_US/translation.json b/shared/i18n/locales/en_US/translation.json
index 7bcf46e08..a45d1743b 100644
--- a/shared/i18n/locales/en_US/translation.json
+++ b/shared/i18n/locales/en_US/translation.json
@@ -689,6 +689,7 @@
   "Toggle navigation": "Toggle navigation",
   "Focus search input": "Focus search input",
   "Open this guide": "Open this guide",
+  "Enter": "Enter",
   "Publish document and exit": "Publish document and exit",
   "Save document": "Save document",
   "Cancel editing": "Cancel editing",
@@ -701,10 +702,16 @@
   "Undo": "Undo",
   "Redo": "Redo",
   "Lists": "Lists",
+  "Tab": "Tab",
   "Indent list item": "Indent list item",
   "Outdent list item": "Outdent list item",
   "Move list item up": "Move list item up",
   "Move list item down": "Move list item down",
+  "Tables": "Tables",
+  "Insert row": "Insert row",
+  "Next cell": "Next cell",
+  "Previous cell": "Previous cell",
+  "Space": "Space",
   "Numbered list": "Numbered list",
   "Blockquote": "Blockquote",
   "Horizontal divider": "Horizontal divider",