perf: Do not render KeyboardShortcuts guide unless clicked
This commit is contained in:
@@ -1,36 +1,31 @@
|
|||||||
|
import { observer } from "mobx-react";
|
||||||
import { KeyboardIcon } from "outline-icons";
|
import { KeyboardIcon } from "outline-icons";
|
||||||
import * as React from "react";
|
import * as React from "react";
|
||||||
import { useTranslation } from "react-i18next";
|
import { useTranslation } from "react-i18next";
|
||||||
import styled from "styled-components";
|
import styled from "styled-components";
|
||||||
import breakpoint from "styled-components-breakpoint";
|
import breakpoint from "styled-components-breakpoint";
|
||||||
import KeyboardShortcuts from "~/scenes/KeyboardShortcuts";
|
import KeyboardShortcuts from "~/scenes/KeyboardShortcuts";
|
||||||
import Guide from "~/components/Guide";
|
|
||||||
import NudeButton from "~/components/NudeButton";
|
import NudeButton from "~/components/NudeButton";
|
||||||
import Tooltip from "~/components/Tooltip";
|
import Tooltip from "~/components/Tooltip";
|
||||||
import useBoolean from "~/hooks/useBoolean";
|
import useStores from "~/hooks/useStores";
|
||||||
|
|
||||||
function KeyboardShortcutsButton() {
|
function KeyboardShortcutsButton() {
|
||||||
const { t } = useTranslation();
|
const { t } = useTranslation();
|
||||||
const [
|
const { dialogs } = useStores();
|
||||||
keyboardShortcutsOpen,
|
|
||||||
handleOpenKeyboardShortcuts,
|
const handleOpenKeyboardShortcuts = () => {
|
||||||
handleCloseKeyboardShortcuts,
|
dialogs.openGuide({
|
||||||
] = useBoolean();
|
title: t("Keyboard shortcuts"),
|
||||||
|
content: <KeyboardShortcuts />,
|
||||||
|
});
|
||||||
|
};
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<>
|
<Tooltip tooltip={t("Keyboard shortcuts")} shortcut="?" delay={500}>
|
||||||
<Guide
|
<Button onClick={handleOpenKeyboardShortcuts}>
|
||||||
isOpen={keyboardShortcutsOpen}
|
<KeyboardIcon />
|
||||||
onRequestClose={handleCloseKeyboardShortcuts}
|
</Button>
|
||||||
title={t("Keyboard shortcuts")}
|
</Tooltip>
|
||||||
>
|
|
||||||
<KeyboardShortcuts />
|
|
||||||
</Guide>
|
|
||||||
<Tooltip tooltip={t("Keyboard shortcuts")} shortcut="?" delay={500}>
|
|
||||||
<Button onClick={handleOpenKeyboardShortcuts}>
|
|
||||||
<KeyboardIcon />
|
|
||||||
</Button>
|
|
||||||
</Tooltip>
|
|
||||||
</>
|
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -49,4 +44,4 @@ const Button = styled(NudeButton)`
|
|||||||
}
|
}
|
||||||
`;
|
`;
|
||||||
|
|
||||||
export default KeyboardShortcutsButton;
|
export default observer(KeyboardShortcutsButton);
|
||||||
|
|||||||
@@ -442,6 +442,7 @@ const List = styled.dl`
|
|||||||
overflow: hidden;
|
overflow: hidden;
|
||||||
padding: 0;
|
padding: 0;
|
||||||
margin: 0;
|
margin: 0;
|
||||||
|
user-select: none;
|
||||||
`;
|
`;
|
||||||
|
|
||||||
const Keys = styled.dt`
|
const Keys = styled.dt`
|
||||||
|
|||||||
Reference in New Issue
Block a user