From cb40e285f4c3a4ae3ab18f3393289853a7af34d1 Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Fri, 29 Dec 2023 10:18:34 -0500 Subject: [PATCH] chore: Remove RPCAction.Count as default valid action on frontend (Only available for users) --- app/stores/CommentsStore.ts | 9 +-------- app/stores/UsersStore.ts | 11 ++++++++++- app/stores/WebhookSubscriptionStore.ts | 9 +-------- app/stores/base/Store.ts | 1 - 4 files changed, 12 insertions(+), 18 deletions(-) diff --git a/app/stores/CommentsStore.ts b/app/stores/CommentsStore.ts index 537024e08..16e189693 100644 --- a/app/stores/CommentsStore.ts +++ b/app/stores/CommentsStore.ts @@ -3,16 +3,9 @@ import orderBy from "lodash/orderBy"; import { action, computed } from "mobx"; import Comment from "~/models/Comment"; import RootStore from "./RootStore"; -import Store, { RPCAction } from "./base/Store"; +import Store from "./base/Store"; export default class CommentsStore extends Store { - actions = [ - RPCAction.List, - RPCAction.Create, - RPCAction.Update, - RPCAction.Delete, - ]; - constructor(rootStore: RootStore) { super(rootStore, Comment); } diff --git a/app/stores/UsersStore.ts b/app/stores/UsersStore.ts index ab35d1688..619c64e06 100644 --- a/app/stores/UsersStore.ts +++ b/app/stores/UsersStore.ts @@ -6,9 +6,18 @@ import { type JSONObject, UserRole } from "@shared/types"; import User from "~/models/User"; import { client } from "~/utils/ApiClient"; import RootStore from "./RootStore"; -import Store from "./base/Store"; +import Store, { RPCAction } from "./base/Store"; export default class UsersStore extends Store { + actions = [ + RPCAction.Info, + RPCAction.List, + RPCAction.Create, + RPCAction.Update, + RPCAction.Delete, + RPCAction.Count, + ]; + @observable counts: { active: number; diff --git a/app/stores/WebhookSubscriptionStore.ts b/app/stores/WebhookSubscriptionStore.ts index c7ed34492..7ead75fb6 100644 --- a/app/stores/WebhookSubscriptionStore.ts +++ b/app/stores/WebhookSubscriptionStore.ts @@ -1,16 +1,9 @@ import { computed } from "mobx"; import WebhookSubscription from "~/models/WebhookSubscription"; import RootStore from "./RootStore"; -import Store, { RPCAction } from "./base/Store"; +import Store from "./base/Store"; export default class WebhookSubscriptionsStore extends Store { - actions = [ - RPCAction.List, - RPCAction.Create, - RPCAction.Delete, - RPCAction.Update, - ]; - constructor(rootStore: RootStore) { super(rootStore, WebhookSubscription); } diff --git a/app/stores/base/Store.ts b/app/stores/base/Store.ts index bead0ff7c..f449c98f5 100644 --- a/app/stores/base/Store.ts +++ b/app/stores/base/Store.ts @@ -54,7 +54,6 @@ export default abstract class Store { RPCAction.Create, RPCAction.Update, RPCAction.Delete, - RPCAction.Count, ]; constructor(rootStore: RootStore, model: typeof Model) {