yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Handle GitLab can be configured for tokens to not expire. (#4051)

Browse Source 
closes #4040
This commit is contained in:
Tom Moor
2022-09-04 12:56:00 +02:00
committed by GitHub
parent c9156ae399
commit c964163cc5
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
server/models/UserAuthentication.ts
View File

@@ -142,7 +142,13 @@ class UserAuthentication extends IdModel {
authenticationProvider: AuthenticationProvider, authenticationProvider: AuthenticationProvider,
options: SaveOptions options: SaveOptions
): Promise<boolean> { ): Promise<boolean> {
if (this.expiresAt > addMinutes(Date.now(), 5) || !this.refreshToken) { if (
this.expiresAt > addMinutes(Date.now(), 5) ||
!this.refreshToken ||
// Some providers send no expiry depending on setup, in this case we can't
// refresh and assume the session is valid until logged out.
!this.expiresAt
) {
return false; return false;
} }
@@ -162,7 +168,7 @@ class UserAuthentication extends IdModel {
} }
this.accessToken = response.accessToken; this.accessToken = response.accessToken;
this.expiresAt = response.expiresAt; this.expiresAt = response.expiresAt;
this.save(options); await this.save(options);
} }
Logger.info("utils", "Successfully refreshed expired access token", { Logger.info("utils", "Successfully refreshed expired access token", {