yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: React devmode warnings (#5169

Browse Source 
* fix: React warning: Cannot change state from within render

* Remove usage of react-side-effect
This commit is contained in:
Tom Moor
2023-04-08 10:17:31 -04:00
committed by GitHub
parent dcb15bae13
commit c82b05a044
8 changed files with 54 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/editor/components/SelectionToolbar.tsx
View File

@@ -81,13 +81,15 @@ export default function SelectionToolbar(props: Props) {
const isActive = useIsActive(view.state);
const previousIsActuve = usePrevious(isActive);
// Trigger callbacks when the toolbar is opened or closed
if (previousIsActuve && !isActive) {
onClose();
}
if (!previousIsActuve && isActive) {
onOpen();
}
React.useEffect(() => {
// Trigger callbacks when the toolbar is opened or closed
if (previousIsActuve && !isActive) {
onClose();
}
if (!previousIsActuve && isActive) {
onOpen();
}
}, [isActive, onClose, onOpen, previousIsActuve]);
React.useEffect(() => {
const handleClickOutside = (ev: MouseEvent): void => {