yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: RangeError when resolving or removing comment across marks, closes #7182

Browse Source
This commit is contained in:
Tom Moor
2024-07-02 18:24:23 -04:00
parent 8a8dad15ef
commit c5b94e50df
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/editor/index.tsx
View File

@@ -646,6 +646,7 @@ export class Editor extends React.PureComponent<
*/ */
public removeComment = (commentId: string) => { public removeComment = (commentId: string) => {
const { state, dispatch } = this.view; const { state, dispatch } = this.view;
const tr = state.tr;
state.doc.descendants((node, pos) => { state.doc.descendants((node, pos) => {
if (!node.isInline) { if (!node.isInline) {
@@ -657,9 +658,11 @@ export class Editor extends React.PureComponent<
); );
if (mark) { if (mark) {
dispatch(state.tr.removeMark(pos, pos + node.nodeSize, mark)); tr.removeMark(pos, pos + node.nodeSize, mark);
} }
}); });
dispatch(tr);
}; };
/** /**
@@ -670,6 +673,7 @@ export class Editor extends React.PureComponent<
*/ */
public updateComment = (commentId: string, attrs: { resolved: boolean }) => { public updateComment = (commentId: string, attrs: { resolved: boolean }) => {
const { state, dispatch } = this.view; const { state, dispatch } = this.view;
const tr = state.tr;
state.doc.descendants((node, pos) => { state.doc.descendants((node, pos) => {
if (!node.isInline) { if (!node.isInline) {
@@ -687,11 +691,12 @@ export class Editor extends React.PureComponent<
...mark.attrs, ...mark.attrs,
...attrs, ...attrs,
}); });
dispatch(
state.tr.removeMark(from, to, mark).addMark(from, to, newMark) tr.removeMark(from, to, mark).addMark(from, to, newMark);
);
} }
}); });
dispatch(tr);
}; };
/** /**