From c33a4103e7aa47c6f17c6ef9e9ec3f0031ca3641 Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Mon, 20 Feb 2023 11:24:14 -0500 Subject: [PATCH] chore: Remove `setimmediate` polyfill (#4903) * Add setimmediate to dependencies * Remove use of setimmediate --- app/components/DocumentExplorer.tsx | 2 +- app/index.tsx | 1 - app/scenes/Settings/components/ImageUpload.tsx | 2 +- app/stores/AuthStore.ts | 2 +- package.json | 2 +- shared/editor/components/Frame.tsx | 2 +- 6 files changed, 5 insertions(+), 6 deletions(-) diff --git a/app/components/DocumentExplorer.tsx b/app/components/DocumentExplorer.tsx index 82b0ab1cb..4cce1706f 100644 --- a/app/components/DocumentExplorer.tsx +++ b/app/components/DocumentExplorer.tsx @@ -311,7 +311,7 @@ function DocumentExplorer({ onSubmit, onSelect, items }: Props) { if (!searchTerm) { toggleCollapse(activeNode); // let the nodes re-render first and then scroll - setImmediate(() => scrollNodeIntoView(activeNode)); + setTimeout(() => scrollNodeIntoView(activeNode), 0); } break; } diff --git a/app/index.tsx b/app/index.tsx index e0f34dbf7..b243a2803 100644 --- a/app/index.tsx +++ b/app/index.tsx @@ -1,7 +1,6 @@ // eslint-disable-next-line import/no-unresolved import "vite/modulepreload-polyfill"; import "focus-visible"; -import "setimmediate"; import { LazyMotion } from "framer-motion"; import { KBarProvider } from "kbar"; import { Provider } from "mobx-react"; diff --git a/app/scenes/Settings/components/ImageUpload.tsx b/app/scenes/Settings/components/ImageUpload.tsx index 0640e9f71..bea1b6386 100644 --- a/app/scenes/Settings/components/ImageUpload.tsx +++ b/app/scenes/Settings/components/ImageUpload.tsx @@ -53,7 +53,7 @@ class ImageUpload extends React.Component { this.isUploading = true; // allow the UI to update before converting the canvas to a Blob // for large images this can cause the page rendering to hang. - setImmediate(this.uploadImage); + setTimeout(this.uploadImage, 0); }; uploadImage = async () => { diff --git a/app/stores/AuthStore.ts b/app/stores/AuthStore.ts index 42bb6d8b5..876abd4df 100644 --- a/app/stores/AuthStore.ts +++ b/app/stores/AuthStore.ts @@ -128,7 +128,7 @@ export default class AuthStore { this.addPolicies(data.policies); if (this.token) { - setImmediate(() => this.fetch()); + setTimeout(() => this.fetch(), 0); } } diff --git a/package.json b/package.json index bac586c14..ee82f2d8a 100644 --- a/package.json +++ b/package.json @@ -147,11 +147,11 @@ "nodemailer": "^6.6.1", "outline-icons": "^1.46.0", "oy-vey": "^0.12.0", - "patch-package": "^6.5.1", "passport": "^0.6.0", "passport-google-oauth2": "^0.2.0", "passport-oauth2": "^1.6.1", "passport-slack-oauth2": "^1.1.1", + "patch-package": "^6.5.1", "pg": "^8.8.0", "pg-hstore": "^2.3.4", "pg-tsquery": "^8.4.0", diff --git a/shared/editor/components/Frame.tsx b/shared/editor/components/Frame.tsx index 751f0ce7e..725b14eb1 100644 --- a/shared/editor/components/Frame.tsx +++ b/shared/editor/components/Frame.tsx @@ -30,7 +30,7 @@ class Frame extends React.Component { componentDidMount() { this.mounted = true; - setImmediate(this.loadIframe); + setTimeout(this.loadIframe, 0); } componentWillUnmount() {