fix: handle errors from Iframely

app/components/HoverPreview/HoverPreview.tsx

@@ -93,7 +93,7 @@ function HoverPreviewInternal({ element, onClose }: Props) {
   React.useEffect(() => {
     const card = cardRef.current;
 
-    if (data) {
+    if (data && !data.error) {
       startOpenTimer();
 
       if (card) {
@@ -134,7 +134,7 @@ function HoverPreviewInternal({ element, onClose }: Props) {
     return <LoadingIndicator />;
   }
 
-  if (!data) {
+  if (!data || data.error) {
     return null;
   }
 

server/presenters/unfurls/unfurl.ts

@@ -1,13 +1,18 @@
-import { Unfurl } from "@shared/types";
+import { IframelyErrorResponse, Unfurl } from "@shared/types";
 
-function presentUnfurl(data: any): Unfurl {
+function presentUnfurl(data: any): Unfurl | IframelyErrorResponse {
-  return {
+  return !data.error
+    ? {
         url: data.url,
         type: data.type,
         title: data.title,
         description: data.description,
         thumbnailUrl: data.thumbnail_url,
         meta: data.meta,
+      }
+    : {
+        status: data.status,
+        error: data.error,
       };
 }
 

server/routes/api/urls/urls.ts

@@ -63,6 +63,9 @@ router.post(
     }
 
     const data = await Iframely.unfurl(url);
+    if (data.error) {
+      ctx.response.status = data.status;
+    }
     ctx.body = presentUnfurl(data);
   }
 );

shared/types.ts

@@ -225,5 +225,10 @@ export type Unfurl<T = OEmbedType> = {
   meta?: Record<string, string>;
 };
 
+export type IframelyErrorResponse = {
+  status: number;
+  error: string;
+};
+
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
 export type ProsemirrorData = Record<string, any>;