From bc918b7bf5df12147efb7d39417e5a93eacf7e65 Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Tue, 23 Apr 2019 20:30:40 -0700 Subject: [PATCH] Fixes: Search filter dropdown should close on selection --- app/scenes/Search/components/FilterOption.js | 1 + app/scenes/Search/components/FilterOptions.js | 27 +++++++++++-------- 2 files changed, 17 insertions(+), 11 deletions(-) diff --git a/app/scenes/Search/components/FilterOption.js b/app/scenes/Search/components/FilterOption.js index ac72c0cc0..627597d9e 100644 --- a/app/scenes/Search/components/FilterOption.js +++ b/app/scenes/Search/components/FilterOption.js @@ -44,6 +44,7 @@ const Anchor = styled('a')` ${HelpText} { font-weight: normal; + user-select: none; } &:hover { diff --git a/app/scenes/Search/components/FilterOptions.js b/app/scenes/Search/components/FilterOptions.js index 1a479a25c..513528480 100644 --- a/app/scenes/Search/components/FilterOptions.js +++ b/app/scenes/Search/components/FilterOptions.js @@ -31,16 +31,21 @@ const FilterOptions = ({ return ( - - {options.map(option => ( - onSelect(option.key)} - active={option.key === activeKey} - {...option} - /> - ))} - + {({ closeMenu }) => ( + + {options.map(option => ( + { + onSelect(option.key); + closeMenu(); + }} + active={option.key === activeKey} + {...option} + /> + ))} + + )} ); }; @@ -78,7 +83,7 @@ const SearchFilter = props => { > {({ closePortal }) => ( - {props.children} + {props.children({ closeMenu: closePortal })} )}