From bc3271b4ab2c7aa07e3147cbb31b160fc1b69b83 Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Fri, 23 Feb 2024 21:02:52 -0500 Subject: [PATCH] fix: Passing publish=true in documents.update with published document errors --- server/routes/api/documents/documents.test.ts | 1 + server/routes/api/documents/documents.ts | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/server/routes/api/documents/documents.test.ts b/server/routes/api/documents/documents.test.ts index 988766e93..9ea8b7826 100644 --- a/server/routes/api/documents/documents.test.ts +++ b/server/routes/api/documents/documents.test.ts @@ -3032,6 +3032,7 @@ describe("#documents.update", () => { id: document.id, title: "Updated title", text: "Updated text", + publish: true, }, }); const body = await res.json(); diff --git a/server/routes/api/documents/documents.ts b/server/routes/api/documents/documents.ts index b85d610a9..ad1aa6f03 100644 --- a/server/routes/api/documents/documents.ts +++ b/server/routes/api/documents/documents.ts @@ -990,7 +990,10 @@ router.post( } if (publish) { - authorize(user, "publish", document); + if (document.isDraft) { + authorize(user, "publish", document); + } + if (!document.collectionId) { assertPresent( collectionId,