yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Do not rely on class names in production bundle (#6212)

Browse Source
This commit is contained in:
Tom Moor
2023-11-24 12:59:57 -05:00
committed by GitHub
parent 13a6f89640
commit b9767a9fdc
38 changed files with 202 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/models/decorators/Relation.ts
View File

@@ -35,7 +35,9 @@ export const getInverseRelationsForModelClass = (targetClass: typeof Model) => {
relations.forEach((relation, modelName) => {
relation.forEach((properties, propertyName) => {
if (properties.relationClassResolver().name === targetClass.name) {
if (
properties.relationClassResolver().modelName === targetClass.modelName
) {
inverseRelations.set(propertyName, {
...properties,
modelName,
@@ -66,13 +68,13 @@ export default function Relation<T extends typeof Model>(
// this to determine how to update relations when a model is deleted.
if (options) {
const configForClass =
relations.get(target.constructor.name) || new Map();
relations.get(target.constructor.modelName) || new Map();
configForClass.set(propertyKey, {
options,
relationClassResolver: classResolver,
idKey,
});
relations.set(target.constructor.name, configForClass);
relations.set(target.constructor.modelName, configForClass);
}
Object.defineProperty(target, propertyKey, {
@@ -83,9 +85,9 @@ export default function Relation<T extends typeof Model>(
return undefined;
}
const relationClassName = classResolver().name;
const relationClassName = classResolver().modelName;
const store =
this.store.rootStore[`${relationClassName.toLowerCase()}s`];
this.store.rootStore.getStoreForModelName(relationClassName);
invariant(store, `Store for ${relationClassName} not found`);
return store.get(id);
@@ -94,9 +96,9 @@ export default function Relation<T extends typeof Model>(
this[idKey] = newValue ? newValue.id : undefined;
if (newValue) {
const relationClassName = classResolver().name;
const relationClassName = classResolver().modelName;
const store =
this.store.rootStore[`${relationClassName.toLowerCase()}s`];
this.store.rootStore.getStoreForModelName(relationClassName);
invariant(store, `Store for ${relationClassName} not found`);
store.add(newValue);