fix: Restore ability to disable embeds on a document (#1238)

closes #1237
This commit is contained in:
Tom Moor
2020-04-21 21:43:01 -07:00
committed by GitHub
parent cead37051e
commit 9f8e7be755
3 changed files with 30 additions and 3 deletions

View File

@@ -123,6 +123,7 @@ class DocumentMenu extends React.Component<Props> {
document,
position,
className,
showToggleEmbeds,
showPrint,
showPin,
auth,
@@ -177,6 +178,19 @@ class DocumentMenu extends React.Component<Props> {
Share link
</DropdownMenuItem>
)}
{showToggleEmbeds && (
<React.Fragment>
{document.embedsDisabled ? (
<DropdownMenuItem onClick={document.enableEmbeds}>
Enable embeds
</DropdownMenuItem>
) : (
<DropdownMenuItem onClick={document.disableEmbeds}>
Disable embeds
</DropdownMenuItem>
)}
</React.Fragment>
)}
{canViewHistory && (
<React.Fragment>
<hr />

View File

@@ -1,5 +1,5 @@
// @flow
import { action, set, computed } from 'mobx';
import { action, set, observable, computed } from 'mobx';
import pkg from 'rich-markdown-editor/package.json';
import addDays from 'date-fns/add_days';
import invariant from 'invariant';
@@ -15,7 +15,8 @@ import DocumentsStore from 'stores/DocumentsStore';
type SaveOptions = { publish?: boolean, done?: boolean, autosave?: boolean };
export default class Document extends BaseModel {
isSaving: boolean;
@observable isSaving: boolean = false;
@observable embedsDisabled: boolean = false;
store: DocumentsStore;
collaborators: User[];
@@ -110,6 +111,17 @@ export default class Document extends BaseModel {
return this.store.restore(this, revision);
};
@action
enableEmbeds = () => {
this.embedsDisabled = false;
};
@action
disableEmbeds = () => {
this.embedsDisabled = true;
debugger;
};
@action
pin = async () => {
this.pinned = true;

View File

@@ -275,7 +275,8 @@ class DocumentScene extends React.Component<Props> {
return <Loading location={location} />;
}
const disableEmbeds = team && team.documentEmbeds === false;
const disableEmbeds =
(team && team.documentEmbeds === false) || document.embedsDisabled;
return (
<ErrorBoundary>