yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: ♻️ refactor isHosted && type clean up (#3290)

Browse Source 
* refactor: ♻️ refactor isHosted && type clean up

Change-Id: I4dfbad8a07607432801de78920ce42bf81e46498

* refactor: ♻️ code clean up

Change-Id: I8f487a33d332a2acaff84397a97371b56ace28a1

* feat: 💄 lint

Change-Id: I776b1a5e249bdb542f8e6da7cb2277821cf91094

* feat: ✨ ci type

Change-Id: I486dde7bf60321238e9a394c40ad8cdb8bfc54c8

* feat: some code sugession

Change-Id: I4761d057344b95a98e99068d312a42292977875b
This commit is contained in:
忽如寄
2022-03-28 06:18:37 +08:00
committed by GitHub
parent f7b1f3ad6d
commit 9f400af73b
58 changed files with 131 additions and 161 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
app/stores/AuthStore.ts
View File

@@ -146,7 +146,7 @@ export default class AuthStore {
@action
fetchConfig = async () => {
const res = await client.post("/auth.config");
invariant(res && res.data, "Config not available");
invariant(res?.data, "Config not available");
this.config = res.data;
};
@@ -154,7 +154,7 @@ export default class AuthStore {
fetch = async () => {
try {
const res = await client.post("/auth.info");
invariant(res && res.data, "Auth not available");
invariant(res?.data, "Auth not available");
runInAction("AuthStore#fetch", () => {
this.addPolicies(res.policies);
const { user, team } = res.data;
@@ -212,7 +212,7 @@ export default class AuthStore {
try {
const res = await client.post(`/users.update`, params);
invariant(res && res.data, "User response not available");
invariant(res?.data, "User response not available");
runInAction("AuthStore#updateUser", () => {
this.addPolicies(res.policies);
this.user = new User(res.data, this);
@@ -235,7 +235,7 @@ export default class AuthStore {
try {
const res = await client.post(`/team.update`, params);
invariant(res && res.data, "Team response not available");
invariant(res?.data, "Team response not available");
runInAction("AuthStore#updateTeam", () => {
this.addPolicies(res.policies);
this.team = new Team(res.data, this);

8
app/stores/BaseStore.ts
View File

@@ -138,7 +138,7 @@ export default class BaseStore<T extends BaseModel> {
...options,
});
invariant(res && res.data, "Data should be available");
invariant(res?.data, "Data should be available");
this.addPolicies(res.policies);
return this.add(res.data);
} finally {
@@ -163,7 +163,7 @@ export default class BaseStore<T extends BaseModel> {
...options,
});
invariant(res && res.data, "Data should be available");
invariant(res?.data, "Data should be available");
this.addPolicies(res.policies);
return this.add(res.data);
} finally {
@@ -206,7 +206,7 @@ export default class BaseStore<T extends BaseModel> {
const res = await client.post(`/${this.apiEndpoint}.info`, {
id,
});
invariant(res && res.data, "Data should be available");
invariant(res?.data, "Data should be available");
this.addPolicies(res.policies);
return this.add(res.data);
} catch (err) {
@@ -230,7 +230,7 @@ export default class BaseStore<T extends BaseModel> {
try {
const res = await client.post(`/${this.apiEndpoint}.list`, params);
invariant(res && res.data, "Data not available");
invariant(res?.data, "Data not available");
runInAction(`list#${this.modelName}`, () => {
this.addPolicies(res.policies);

4
app/stores/CollectionGroupMembershipsStore.ts
View File

@@ -21,7 +21,7 @@ export default class CollectionGroupMembershipsStore extends BaseStore<
try {
const res = await client.post(`/collections.group_memberships`, params);
invariant(res && res.data, "Data not available");
invariant(res?.data, "Data not available");
runInAction(`CollectionGroupMembershipsStore#fetchPage`, () => {
res.data.groups.forEach(this.rootStore.groups.add);
res.data.collectionGroupMemberships.forEach(this.add);
@@ -48,7 +48,7 @@ export default class CollectionGroupMembershipsStore extends BaseStore<
groupId,
permission,
});
invariant(res && res.data, "Membership data should be available");
invariant(res?.data, "Membership data should be available");
const cgm = res.data.collectionGroupMemberships.map(this.add);
return cgm[0];

4
app/stores/CollectionsStore.ts
View File

@@ -111,7 +111,7 @@ export default class CollectionsStore extends BaseStore<Collection> {
id: collectionId,
index,
});
invariant(res && res.success, "Collection could not be moved");
invariant(res?.success, "Collection could not be moved");
const collection = this.get(collectionId);
if (collection) {
@@ -153,7 +153,7 @@ export default class CollectionsStore extends BaseStore<Collection> {
const res = await client.post(`/collections.info`, {
id,
});
invariant(res && res.data, "Collection not available");
invariant(res?.data, "Collection not available");
this.addPolicies(res.policies);
return this.add(res.data);
} catch (err) {

26
app/stores/DocumentsStore.ts
View File

@@ -239,7 +239,7 @@ export default class DocumentsStore extends BaseStore<Document> {
const res = await client.post(`/documents.list`, {
backlinkDocumentId: documentId,
});
invariant(res && res.data, "Document list not available");
invariant(res?.data, "Document list not available");
const { data } = res;
runInAction("DocumentsStore#fetchBacklinks", () => {
@@ -271,7 +271,7 @@ export default class DocumentsStore extends BaseStore<Document> {
const res = await client.post(`/documents.list`, {
parentDocumentId: documentId,
});
invariant(res && res.data, "Document list not available");
invariant(res?.data, "Document list not available");
const { data } = res;
runInAction("DocumentsStore#fetchChildDocuments", () => {
@@ -289,7 +289,7 @@ export default class DocumentsStore extends BaseStore<Document> {
try {
const res = await client.post(`/documents.${request}`, options);
invariant(res && res.data, "Document list not available");
invariant(res?.data, "Document list not available");
runInAction("DocumentsStore#fetchNamedPage", () => {
res.data.forEach(this.add);
this.addPolicies(res.policies);
@@ -375,7 +375,7 @@ export default class DocumentsStore extends BaseStore<Document> {
const res = await client.get("/documents.search_titles", {
query,
});
invariant(res && res.data, "Search response should be available");
invariant(res?.data, "Search response should be available");
// add the documents and associated policies to the store
res.data.forEach(this.add);
this.addPolicies(res.policies);
@@ -392,7 +392,7 @@ export default class DocumentsStore extends BaseStore<Document> {
...compactedOptions,
query,
});
invariant(res && res.data, "Search response should be available");
invariant(res?.data, "Search response should be available");
// add the documents and associated policies to the store
res.data.forEach((result: SearchResult) => this.add(result.document));
@@ -443,7 +443,7 @@ export default class DocumentsStore extends BaseStore<Document> {
const res = await client.post("/documents.templatize", {
id,
});
invariant(res && res.data, "Document not available");
invariant(res?.data, "Document not available");
this.addPolicies(res.policies);
this.add(res.data);
return this.data.get(res.data.id);
@@ -485,7 +485,7 @@ export default class DocumentsStore extends BaseStore<Document> {
apiVersion: 2,
});
invariant(res && res.data, "Document not available");
invariant(res?.data, "Document not available");
this.addPolicies(res.policies);
this.add(res.data.document);
@@ -524,7 +524,7 @@ export default class DocumentsStore extends BaseStore<Document> {
parentDocumentId,
index: index,
});
invariant(res && res.data, "Data not available");
invariant(res?.data, "Data not available");
res.data.documents.forEach(this.add);
res.data.collections.forEach(this.rootStore.collections.add);
this.addPolicies(res.policies);
@@ -547,7 +547,7 @@ export default class DocumentsStore extends BaseStore<Document> {
)}${append}`,
text: document.text,
});
invariant(res && res.data, "Data should be available");
invariant(res?.data, "Data should be available");
const collection = this.getCollectionForDocument(document);
if (collection) {
collection.refresh();
@@ -613,7 +613,7 @@ export default class DocumentsStore extends BaseStore<Document> {
}
});
const res = await client.post("/documents.import", formData);
invariant(res && res.data, "Data should be available");
invariant(res?.data, "Data should be available");
this.addPolicies(res.policies);
return this.add(res.data);
};
@@ -680,7 +680,7 @@ export default class DocumentsStore extends BaseStore<Document> {
id: document.id,
});
runInAction("Document#archive", () => {
invariant(res && res.data, "Data should be available");
invariant(res?.data, "Data should be available");
document.updateFromJson(res.data);
this.addPolicies(res.policies);
});
@@ -704,7 +704,7 @@ export default class DocumentsStore extends BaseStore<Document> {
collectionId: options.collectionId,
});
runInAction("Document#restore", () => {
invariant(res && res.data, "Data should be available");
invariant(res?.data, "Data should be available");
document.updateFromJson(res.data);
this.addPolicies(res.policies);
});
@@ -720,7 +720,7 @@ export default class DocumentsStore extends BaseStore<Document> {
id: document.id,
});
runInAction("Document#unpublish", () => {
invariant(res && res.data, "Data should be available");
invariant(res?.data, "Data should be available");
document.updateFromJson(res.data);
this.addPolicies(res.policies);
});

6
app/stores/GroupMembershipsStore.ts
View File

@@ -20,7 +20,7 @@ export default class GroupMembershipsStore extends BaseStore<GroupMembership> {
try {
const res = await client.post(`/groups.memberships`, params);
invariant(res && res.data, "Data not available");
invariant(res?.data, "Data not available");
runInAction(`GroupMembershipsStore#fetchPage`, () => {
res.data.users.forEach(this.rootStore.users.add);
res.data.groupMemberships.forEach(this.add);
@@ -38,7 +38,7 @@ export default class GroupMembershipsStore extends BaseStore<GroupMembership> {
id: groupId,
userId,
});
invariant(res && res.data, "Group Membership data should be available");
invariant(res?.data, "Group Membership data should be available");
res.data.users.forEach(this.rootStore.users.add);
res.data.groups.forEach(this.rootStore.groups.add);
@@ -52,7 +52,7 @@ export default class GroupMembershipsStore extends BaseStore<GroupMembership> {
id: groupId,
userId,
});
invariant(res && res.data, "Group Membership data should be available");
invariant(res?.data, "Group Membership data should be available");
this.remove(`${userId}-${groupId}`);
runInAction(`GroupMembershipsStore#delete`, () => {
res.data.groups.forEach(this.rootStore.groups.add);

2
app/stores/GroupsStore.ts
View File

@@ -26,7 +26,7 @@ export default class GroupsStore extends BaseStore<Group> {
try {
const res = await client.post(`/groups.list`, params);
invariant(res && res.data, "Data not available");
invariant(res?.data, "Data not available");
runInAction(`GroupsStore#fetchPage`, () => {
this.addPolicies(res.policies);
res.data.groups.forEach(this.add);

4
app/stores/MembershipsStore.ts
View File

@@ -19,7 +19,7 @@ export default class MembershipsStore extends BaseStore<Membership> {
try {
const res = await client.post(`/collections.memberships`, params);
invariant(res && res.data, "Data not available");
invariant(res?.data, "Data not available");
runInAction(`/collections.memberships`, () => {
res.data.users.forEach(this.rootStore.users.add);
res.data.memberships.forEach(this.add);
@@ -46,7 +46,7 @@ export default class MembershipsStore extends BaseStore<Membership> {
userId,
permission,
});
invariant(res && res.data, "Membership data should be available");
invariant(res?.data, "Membership data should be available");
res.data.users.forEach(this.rootStore.users.add);
const memberships = res.data.memberships.map(this.add);

2
app/stores/PinsStore.ts
View File

@@ -19,7 +19,7 @@ export default class PinsStore extends BaseStore<Pin> {
try {
const res = await client.post(`/pins.list`, params);
invariant(res && res.data, "Data not available");
invariant(res?.data, "Data not available");
runInAction(`PinsStore#fetchPage`, () => {
res.data.documents.forEach(this.rootStore.documents.add);
res.data.pins.forEach(this.add);

2
app/stores/RevisionsStore.ts
View File

@@ -53,7 +53,7 @@ export default class RevisionsStore extends BaseStore<Revision> {
try {
const res = await client.post("/revisions.list", options);
invariant(res && res.data, "Document revisions not available");
invariant(res?.data, "Document revisions not available");
runInAction("RevisionsStore#fetchPage", () => {
res.data.forEach(this.add);
this.isLoaded = true;

4
app/stores/SharesStore.ts
View File

@@ -65,7 +65,7 @@ export default class SharesStore extends BaseStore<Share> {
if (isUndefined(res)) {
return;
}
invariant(res && res.data, "Data should be available");
invariant(res?.data, "Data should be available");
this.addPolicies(res.policies);
return res.data.shares.map(this.add);
} finally {
@@ -92,7 +92,7 @@ export default class SharesStore extends BaseStore<Share> {
for (const parentId of parentIds) {
const share = this.getByDocumentId(parentId);
if (share && share.includeChildDocuments && share.published) {
if (share?.includeChildDocuments && share.published) {
return share;
}
}

2
app/stores/StarsStore.ts
View File

@@ -17,7 +17,7 @@ export default class StarsStore extends BaseStore<Star> {
try {
const res = await client.post(`/stars.list`, params);
invariant(res && res.data, "Data not available");
invariant(res?.data, "Data not available");
runInAction(`StarsStore#fetchPage`, () => {
res.data.documents.forEach(this.rootStore.documents.add);
res.data.stars.forEach(this.add);

2
app/stores/ToastsStore.ts
View File

@@ -21,7 +21,7 @@ export default class ToastsStore {
}
const lastToast = this.toasts.get(this.lastToastId);
if (lastToast && lastToast.message === message) {
if (lastToast?.message === message) {
this.toasts.set(this.lastToastId, {
...lastToast,
reoccurring: lastToast.reoccurring ? ++lastToast.reoccurring : 1,

6
app/stores/UsersStore.ts
View File

@@ -126,7 +126,7 @@ export default class UsersStore extends BaseStore<User> {
const res = await client.post(`/users.invite`, {
invites,
});
invariant(res && res.data, "Data should be available");
invariant(res?.data, "Data should be available");
runInAction(`invite`, () => {
res.data.users.forEach(this.add);
this.counts.invited += res.data.sent.length;
@@ -140,7 +140,7 @@ export default class UsersStore extends BaseStore<User> {
const res = await client.post(`/users.count`, {
teamId,
});
invariant(res && res.data, "Data should be available");
invariant(res?.data, "Data should be available");
this.counts = res.data.counts;
return res.data;
};
@@ -268,7 +268,7 @@ export default class UsersStore extends BaseStore<User> {
id: user.id,
to,
});
invariant(res && res.data, "Data should be available");
invariant(res?.data, "Data should be available");
runInAction(`UsersStore#${action}`, () => {
this.addPolicies(res.policies);
this.add(res.data);