From 9ac1e13227b797c158ad914128bf3761614547e4 Mon Sep 17 00:00:00 2001
From: Apoorv Mishra <apoorvmishra101092@gmail.com>
Date: Tue, 25 Jul 2023 08:46:45 +0530
Subject: [PATCH] fix: just return 204

---
 app/components/HoverPreview/HoverPreview.tsx | 4 ++--
 server/routes/api/urls/urls.ts               | 3 ++-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/app/components/HoverPreview/HoverPreview.tsx b/app/components/HoverPreview/HoverPreview.tsx
index 94224e900..da68fed4c 100644
--- a/app/components/HoverPreview/HoverPreview.tsx
+++ b/app/components/HoverPreview/HoverPreview.tsx
@@ -93,7 +93,7 @@ function HoverPreviewInternal({ element, onClose }: Props) {
   React.useEffect(() => {
     const card = cardRef.current;
 
-    if (data && !data.error) {
+    if (data) {
       startOpenTimer();
 
       if (card) {
@@ -134,7 +134,7 @@ function HoverPreviewInternal({ element, onClose }: Props) {
     return <LoadingIndicator />;
   }
 
-  if (!data || data.error) {
+  if (!data) {
     return null;
   }
 
diff --git a/server/routes/api/urls/urls.ts b/server/routes/api/urls/urls.ts
index 9e90112e4..d424d637a 100644
--- a/server/routes/api/urls/urls.ts
+++ b/server/routes/api/urls/urls.ts
@@ -64,7 +64,8 @@ router.post(
 
     const data = await Iframely.unfurl(url);
     if (data.error) {
-      ctx.response.status = data.status;
+      ctx.response.status = 204;
+      return;
     }
     ctx.body = presentUnfurl(data);
   }