yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat: Allow commenting in code (#5953)

Browse Source 
* Allow commenting in code marks

* Allow commenting in code blocks

* Floating comment toolbar in code block
This commit is contained in:
Tom Moor
2023-10-06 09:56:59 -04:00
committed by GitHub
parent ac319de1df
commit 9924fa6621
10 changed files with 42 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
shared/editor/marks/Comment.ts
View File

@@ -109,14 +109,16 @@ export default class Comment extends Mark {
props: {
handleDOMEvents: {
mouseup: (_view, event: MouseEvent) => {
if (
!(event.target instanceof HTMLSpanElement) ||
!event.target.classList.contains("comment-marker")
) {
if (!(event.target instanceof HTMLElement)) {
return false;
}
const commentId = event.target.id.replace("comment-", "");
const comment = event.target.closest(".comment-marker");
if (!comment) {
return false;
}
const commentId = comment.id.replace("comment-", "");
if (commentId) {
this.options?.onClickCommentMark?.(commentId);
}