From 9415a357959b1b34ab88db2934841c9244a6c837 Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Fri, 14 Jun 2024 22:22:55 -0400 Subject: [PATCH] chore: Add eslint rule to prevent app imports in shared (see: bf130f99153af2bf516aeb9b4a3b83c01ddbbe42) --- shared/.eslintrc | 9 +++++++-- shared/editor/lib/ExtensionManager.ts | 2 +- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/shared/.eslintrc b/shared/.eslintrc index a35d78729..312064d8f 100644 --- a/shared/.eslintrc +++ b/shared/.eslintrc @@ -8,11 +8,16 @@ "eslint-plugin-react-hooks" ], "rules": { - "no-restricted-imports": ["error", { + "@typescript-eslint/no-restricted-imports": ["error", { "patterns": [{ "group": ["@shared/*"], "message": "Use relative imports." }, { + "allowTypeImports": true, + "group": ["~/*"], + "message": "Do not reference app code from shared code." + }, { + "allowTypeImports": true, "group": ["@server/*"], "message": "Do not reference server code from shared code." }] @@ -22,4 +27,4 @@ "jest": true, "browser": true } -} \ No newline at end of file +} diff --git a/shared/editor/lib/ExtensionManager.ts b/shared/editor/lib/ExtensionManager.ts index ca0a9846a..c12bd8015 100644 --- a/shared/editor/lib/ExtensionManager.ts +++ b/shared/editor/lib/ExtensionManager.ts @@ -5,7 +5,7 @@ import { MarkdownParser } from "prosemirror-markdown"; import { Schema } from "prosemirror-model"; import { EditorView } from "prosemirror-view"; import { Primitive } from "utility-types"; -import { Editor } from "~/editor"; +import type { Editor } from "~/editor"; import Mark from "../marks/Mark"; import Node from "../nodes/Node"; import Extension, { CommandFactory } from "./Extension";