From 930bfd5391c93352374b85f1409085e1b1a2e6f4 Mon Sep 17 00:00:00 2001 From: Tom Moor Date: Wed, 29 Jun 2022 08:28:44 +0200 Subject: [PATCH] fix: Must import fetch, log errors, use git short sha for version --- server/queues/tasks/DeliverWebhookTask.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/server/queues/tasks/DeliverWebhookTask.ts b/server/queues/tasks/DeliverWebhookTask.ts index 32fd6d7dc..3a8e257d5 100644 --- a/server/queues/tasks/DeliverWebhookTask.ts +++ b/server/queues/tasks/DeliverWebhookTask.ts @@ -1,3 +1,4 @@ +import fetch from "fetch-with-proxy"; import invariant from "invariant"; import env from "@server/env"; import Logger from "@server/logging/Logger"; @@ -516,7 +517,9 @@ export default class DeliverWebhookTask extends BaseTask { }); requestHeaders = { "Content-Type": "application/json", - "user-agent": `Outline-Webhooks${env.VERSION ? `/${env.VERSION}` : ""}`, + "user-agent": `Outline-Webhooks${ + env.VERSION ? `/${env.VERSION.slice(0, 7)}` : "" + }`, }; response = await fetch(subscription.url, { method: "POST", @@ -525,6 +528,10 @@ export default class DeliverWebhookTask extends BaseTask { }); status = response.ok ? "success" : "failed"; } catch (err) { + Logger.error("Failed to send webhook", err, { + event, + deliveryId: delivery.id, + }); status = "failed"; }