yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: newMentionIds no longer always in event data, closes #7186

Browse Source
This commit is contained in:
Tom Moor
2024-07-02 18:03:22 -04:00
parent a8d4a5b587
commit 8a8dad15ef
2 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
server/queues/tasks/CommentUpdatedNotificationsTask.ts
View File

@@ -6,6 +6,11 @@ import BaseTask, { TaskPriority } from "./BaseTask";
export default class CommentUpdatedNotificationsTask extends BaseTask<CommentEvent> { export default class CommentUpdatedNotificationsTask extends BaseTask<CommentEvent> {
public async perform(event: CommentUpdateEvent) { public async perform(event: CommentUpdateEvent) {
const newMentionIds = event.data.newMentionIds;
if (!newMentionIds) {
return;
}
const [document, comment] = await Promise.all([ const [document, comment] = await Promise.all([
Document.scope("withCollection").findOne({ Document.scope("withCollection").findOne({
where: { where: {
@@ -20,7 +25,7 @@ export default class CommentUpdatedNotificationsTask extends BaseTask<CommentEve
const mentions = ProsemirrorHelper.parseMentions( const mentions = ProsemirrorHelper.parseMentions(
ProsemirrorHelper.toProsemirror(comment.data) ProsemirrorHelper.toProsemirror(comment.data)
).filter((mention) => event.data.newMentionIds.includes(mention.id)); ).filter((mention) => newMentionIds.includes(mention.id));
const userIdsMentioned: string[] = []; const userIdsMentioned: string[] = [];
for (const mention of mentions) { for (const mention of mentions) {

2
server/types.ts
View File

@@ -342,7 +342,7 @@ export type CommentUpdateEvent = BaseEvent<Comment> & {
documentId: string; documentId: string;
actorId: string; actorId: string;
data: { data: {
newMentionIds: string[]; newMentionIds?: string[];
}; };
}; };