yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Use of view after destroyed, closes #5982

Browse Source
This commit is contained in:
Tom Moor
2023-10-10 19:00:12 -04:00
parent fec1a72780
commit 8354a5bc37
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/editor/index.tsx
View File

@@ -302,7 +302,7 @@ export class Editor extends React.PureComponent<
public componentWillUnmount(): void { public componentWillUnmount(): void {
window.removeEventListener("theme-changed", this.dispatchThemeChanged); window.removeEventListener("theme-changed", this.dispatchThemeChanged);
this.view.destroy(); this.view?.destroy();
this.mutationObserver?.disconnect(); this.mutationObserver?.disconnect();
} }

4
shared/editor/extensions/Prism.ts
View File

@@ -220,7 +220,9 @@ export default function Prism({
// it render un-highlighted and then trigger a defered render of Prism // it render un-highlighted and then trigger a defered render of Prism
// by updating the plugins metadata // by updating the plugins metadata
setTimeout(() => { setTimeout(() => {
view.dispatch(view.state.tr.setMeta("prism", { loaded: true })); if (!view.isDestroyed) {
view.dispatch(view.state.tr.setMeta("prism", { loaded: true }));
}
}, 10); }, 10);
} }
return {}; return {};