yuuza/outline
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Links with strikethrough do not have hover preview (#4841)

Browse Source 
* fix: Links with strikethrough do not have hover preview

* refactor
This commit is contained in:
Tom Moor
2023-02-07 22:36:15 -05:00
committed by GitHub
parent bb1fe1a25f
commit 81f655f402
4 changed files with 39 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
shared/editor/marks/Link.tsx
View File

@@ -10,7 +10,7 @@ import {
Mark as ProsemirrorMark,
} from "prosemirror-model";
import { EditorState, Plugin } from "prosemirror-state";
import { Decoration, DecorationSet } from "prosemirror-view";
import { Decoration, DecorationSet, EditorView } from "prosemirror-view";
import * as React from "react";
import ReactDOM from "react-dom";
import { isExternalUrl, sanitizeUrl } from "../../utils/urls";
@@ -210,29 +210,28 @@ export default class Link extends Mark {
},
},
props: {
decorations: (state) => plugin.getState(state),
decorations: (state: EditorState) => plugin.getState(state),
handleDOMEvents: {
mouseover: (view, event: MouseEvent) => {
mouseover: (view: EditorView, event: MouseEvent) => {
const target = (event.target as HTMLElement)?.closest("a");
if (
event.target instanceof HTMLAnchorElement &&
!event.target.className.includes("ProseMirror-widget") &&
target instanceof HTMLAnchorElement &&
!target.className.includes("ProseMirror-widget") &&
(!view.editable || (view.editable && !view.hasFocus()))
) {
if (this.options.onHoverLink) {
return this.options.onHoverLink(event);
return this.options.onHoverLink(target);
}
}
return false;
},
mousedown: (view, event: MouseEvent) => {
if (
!(event.target instanceof HTMLAnchorElement) ||
event.button !== 0
) {
mousedown: (view: EditorView, event: MouseEvent) => {
const target = (event.target as HTMLElement)?.closest("a");
if (!(target instanceof HTMLAnchorElement) || event.button !== 0) {
return false;
}
if (event.target.matches(".component-attachment *")) {
if (target.matches(".component-attachment *")) {
return false;
}
@@ -240,9 +239,9 @@ export default class Link extends Mark {
// clicking in read-only will navigate
if (!view.editable || (view.editable && !view.hasFocus())) {
const href =
event.target.href ||
(event.target.parentNode instanceof HTMLAnchorElement
? event.target.parentNode.href
target.href ||
(target.parentNode instanceof HTMLAnchorElement
? target.parentNode.href
: "");
try {
@@ -262,7 +261,7 @@ export default class Link extends Mark {
return false;
},
click: (view, event) => {
click: (view: EditorView, event: MouseEvent) => {
if (
!(event.target instanceof HTMLAnchorElement) ||
event.button !== 0