feat: Search shared documents (#3126)

* provide a type-ahead search input on shared document pages that allow search of child document tree
* improve keyboard navigation handling of all search views
* improve coloring on dark mode list selection states
* refactor PaginatedList component to eliminate edge cases
This commit is contained in:
Nan Yu
2022-04-08 10:40:51 -07:00
committed by GitHub
parent 5fb5e69181
commit 75a868e5e8
22 changed files with 804 additions and 168 deletions

View File

@@ -433,7 +433,7 @@ describe("#documents.info", () => {
id: document.id,
},
});
expect(res.status).toEqual(403);
expect(res.status).toEqual(401);
});
it("should require authorization with incorrect token", async () => {
@@ -633,7 +633,7 @@ describe("#documents.export", () => {
id: document.id,
},
});
expect(res.status).toEqual(403);
expect(res.status).toEqual(401);
});
it("should require authorization with incorrect token", async () => {
@@ -944,6 +944,59 @@ describe("#documents.search", () => {
expect(body.data[0].document.text).toEqual("# Much test support");
});
it("should return results using shareId", async () => {
const findableDocument = await buildDocument({
title: "search term",
text: "random text",
});
await buildDocument({
title: "search term",
text: "should not be found",
userId: findableDocument.createdById,
teamId: findableDocument.teamId,
});
const share = await buildShare({
includeChildDocuments: true,
documentId: findableDocument.id,
teamId: findableDocument.teamId,
});
const res = await server.post("/api/documents.search", {
body: {
query: "search term",
shareId: share.id,
},
});
const body = await res.json();
expect(res.status).toEqual(200);
expect(body.data.length).toEqual(1);
expect(body.data[0].document.id).toEqual(share.documentId);
});
it("should not allow search if child documents are not included", async () => {
const findableDocument = await buildDocument({
title: "search term",
text: "random text",
});
const share = await buildShare({
includeChildDocuments: false,
document: findableDocument,
});
const res = await server.post("/api/documents.search", {
body: {
query: "search term",
shareId: share.id,
},
});
expect(res.status).toEqual(400);
});
it("should return results in ranked order", async () => {
const { user } = await seed();
const firstResult = await buildDocument({
@@ -1287,7 +1340,11 @@ describe("#documents.search", () => {
});
it("should require authentication", async () => {
const res = await server.post("/api/documents.search");
const res = await server.post("/api/documents.search", {
body: {
query: "search term",
},
});
const body = await res.json();
expect(res.status).toEqual(401);
expect(body).toMatchSnapshot();