diff --git a/app/embeds/Lucidchart.js b/app/embeds/Lucidchart.js index acb40037f..9c5ee01c2 100644 --- a/app/embeds/Lucidchart.js +++ b/app/embeds/Lucidchart.js @@ -2,7 +2,7 @@ import * as React from "react"; import Frame from "./components/Frame"; -const URL_REGEX = /^https?:\/\/(www\.)?lucidchart.com\/documents\/(embeddedchart|view)\/([0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12})(?:\/.*)?$/; +const URL_REGEX = /^https?:\/\/(www\.|app\.)?lucidchart.com\/documents\/(embeddedchart|view)\/([0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12})(?:\/.*)?$/; type Props = {| attrs: {| diff --git a/app/embeds/Lucidchart.test.js b/app/embeds/Lucidchart.test.js index d4922d11f..dc1a57d9a 100644 --- a/app/embeds/Lucidchart.test.js +++ b/app/embeds/Lucidchart.test.js @@ -10,7 +10,20 @@ describe("Lucidchart", () => { ) ).toBeTruthy(); }); - + test("to be enabled on root link", () => { + expect( + "https://lucidchart.com/documents/view/2f4a79cb-7637-433d-8ffb-27cce65a05e7".match( + match + ) + ).toBeTruthy(); + }); + test("to be enabled on app link", () => { + expect( + "https://app.lucidchart.com/documents/view/2f4a79cb-7637-433d-8ffb-27cce65a05e7".match( + match + ) + ).toBeTruthy(); + }); test("to be enabled on visited link", () => { expect( "https://www.lucidchart.com/documents/view/2f4a79cb-7637-433d-8ffb-27cce65a05e7/0".match( @@ -18,9 +31,17 @@ describe("Lucidchart", () => { ) ).toBeTruthy(); }); + test("to be enabled on embedded link", () => { + expect( + "https://app.lucidchart.com/documents/embeddedchart/1af2bdfa-da7d-4ea1-aa1d-bec5677a9837".match( + match + ) + ).toBeTruthy(); + }); test("to not be enabled elsewhere", () => { expect("https://lucidchart.com".match(match)).toBe(null); + expect("https://app.lucidchart.com".match(match)).toBe(null); expect("https://www.lucidchart.com".match(match)).toBe(null); expect("https://www.lucidchart.com/features".match(match)).toBe(null); expect("https://www.lucidchart.com/documents/view".match(match)).toBe(null);