fix: HoverPreview not showing on collaborative editing teams

types

app/components/HoverPreviewDocument.tsx

@@ -9,7 +9,7 @@ import useStores from "~/hooks/useStores";
 
 type Props = {
   url: string;
-  children: (arg0: React.ReactNode) => React.ReactNode;
+  children: (content: React.ReactNode) => React.ReactNode;
 };
 
 function HoverPreviewDocument({ url, children }: Props) {
@@ -23,20 +23,27 @@ function HoverPreviewDocument({ url, children }: Props) {
   const document = slug ? documents.getByUrl(slug) : undefined;
   if (!document) return null;
 
-  return children(
-    <Content to={document.url}>
-      <Heading>{document.titleWithDefault}</Heading>
-      <DocumentMetaWithViews isDraft={document.isDraft} document={document} />
+  return (
+    <>
+      {children(
+        <Content to={document.url}>
+          <Heading>{document.titleWithDefault}</Heading>
+          <DocumentMetaWithViews
+            isDraft={document.isDraft}
+            document={document}
+          />
 
-      <React.Suspense fallback={<div />}>
-        <Editor
-          key={document.id}
-          defaultValue={document.getSummary()}
-          disableEmbeds
-          readOnly
-        />
-      </React.Suspense>
-    </Content>
+          <React.Suspense fallback={<div />}>
+            <Editor
+              key={document.id}
+              defaultValue={document.getSummary()}
+              disableEmbeds
+              readOnly
+            />
+          </React.Suspense>
+        </Content>
+      )}
+    </>
   );
 }
 
@@ -49,5 +56,4 @@ const Heading = styled.h2`
   color: ${(props) => props.theme.text};
 `;
 
-// @ts-expect-error ts-migrate(2345) FIXME: Argument of type '({ url, children }: Props) => Re... Remove this comment to see the full error message
 export default observer(HoverPreviewDocument);

app/scenes/Document/components/Document.tsx

@@ -497,8 +497,6 @@ class DocumentScene extends React.Component<Props> {
               }
               savingIsDisabled={document.isSaving || this.isEmpty}
               sharedTree={this.props.sharedTree}
-              // @ts-expect-error ts-migrate(2322) FIXME: Type '{ document: Document; shareId: any; isRevisi... Remove this comment to see the full error message
-              goBack={this.goBack}
               onSelectTemplate={this.replaceDocument}
               onSave={this.onSave}
               headings={headings}

app/scenes/Document/components/Editor.tsx

@@ -124,7 +124,7 @@ class DocumentEditor extends React.Component<Props> {
           {...rest}
         />
         {!readOnly && <ClickablePadding onClick={this.focusAtEnd} grow />}
-        {this.activeLinkEvent && !shareId && readOnly && (
+        {this.activeLinkEvent && !shareId && (
           <HoverPreview
             node={this.activeLinkEvent.target as HTMLAnchorElement}
             event={this.activeLinkEvent}

app/scenes/Document/components/Header.tsx

@@ -44,7 +44,6 @@ type Props = {
   publishingIsDisabled: boolean;
   savingIsDisabled: boolean;
   onSelectTemplate: (template: Document) => void;
-  onDiscard: () => void;
   onSave: (options: {
     done?: boolean;
     publish?: boolean;